margelo / react-native-bignumber

🔢 The fastest Big Number library for React Native
https://margelo.io
MIT License
342 stars 12 forks source link

Support for react native 0.71.x for android #57

Closed PadovaY closed 1 year ago

PadovaY commented 1 year ago

hey there, while updating my project to react native 0.71.3 version, I ran into this build issue:

Build file 'PROJECT/node_modules/react-native-bignumber/android/build.gradle' line: 184

* What went wrong:
A problem occurred evaluating project ':react-native-bignumber'.
> Expected directory '/PROJECT/node_modules/react-native/android' to contain exactly one file, however, it contains no files.

I saw in react-native-vision-camera project, you released a fix: https://github.com/mrousavy/react-native-vision-camera/issues/1418

can it be applied here as well? thanks 🙏

zitup commented 1 year ago

[!] Can't merge user_target_xcconfig for pod targets: ["hermes-engine", "Pre-built", "react-native-bignumber"]. Singular build setting CLANG_CXX_LANGUAGE_STANDARD has different values.

I see this error, maybe it's a version issue too

adelbeke commented 1 year ago

+1

hannojg commented 1 year ago

Hey, support for RN 0.71 has been added with release 0.2.0! Please note that from v0.2.0 onwards rn-bignumber is only compatible with RN >= 0.71. For iOS rn-bignumber might be compatible with previous RN versions.

Thankgod20 commented 1 year ago

Still getting same error [!] Can't merge user_target_xcconfig for pod targets: ["hermes-engine", "Pre-built", "react-native-bignumber", "react-native-quick-crypto"]. Singular build setting CLANG_CXX_LANGUAGE_STANDARD has different values.

hannojg commented 1 year ago

That's not the error originally described. Your error seems to originate from iOS, while this issue is about android. Please open a new issue with a reproducible example @Thankgod20, thanks