margelo / react-native-graph

📈 Beautiful, high-performance Graphs and Charts for React Native built with Skia
https://margelo.io
MIT License
2.08k stars 118 forks source link

Data changes aren't animating #115

Closed MaxAst closed 3 weeks ago

MaxAst commented 4 weeks ago

Thanks for this great library! Everything's been working well, apart from the animation on data changes demonstrated in the gifs of the README. I provided a repro using Expo Go here, using the code from your example. Likely caused by different skia versions, I'm using the latest one in my example

https://github.com/user-attachments/assets/4d7af8ee-4efe-4161-bf31-6e5679a175c0

billyjacoby commented 3 weeks ago

Seeing the same issue on my end as well. I've tried with both the latest version - 1.5.0 as well as 1.2.3 and 0.1.233

MaxAst commented 3 weeks ago

I changed to victory and in their docs it says that skia animations only work if the data points length is the same across ranges. Might be the same for this library