Multiple lines in graph

margelo / react-native-graph

📈 Beautiful, high-performance Graphs and Charts for React Native built with Skia

https://margelo.io

MIT License

2.08k stars 118 forks source link

Multiple lines in graph #22

Open Ami-Gohel opened 2 years ago

Ami-Gohel commented 2 years ago

This is not supporting multiple lines in a single chart.

taatiq882 commented 2 years ago

Did you find any solution ? i also require multiple lime graph with sort of same implementation.

chrispader commented 2 years ago

This is not supported at the moment. Unfortunately, i don't think we plan to implement this feature anytime soon.

If you or somebody could open a PR for this, that would be great. What do you think @mrousavy ?

mrousavy commented 2 years ago

I think this requires a few structural changes and is a little bit of work. We don't plan to implement that anytime soon, but if you need this feature developed by us, contact us at hello@margelo.io :)

sidferreira commented 1 year ago

@mrousavy, would a PR be considered?

Ami-Gohel commented 1 year ago

I have creates multiple line graphs with SVG, soon I will make package and make open source.

mrousavy commented 1 year ago

@sidferreira

@mrousavy, would a PR be considered?

Yes! If you shoot me a PR, we can review it :)

youssdevx commented 1 year ago

@sidferreira a PR would be much appreciated 🙏🏽

sidferreira commented 1 year ago

@youssdevx although I had some local work, my main need was cancelled, so I don't know when I'll be able to

youssdevx commented 1 year ago

Could you maybe push your work? I'll try to work on it

sidferreira commented 1 year ago

I'll try

sidferreira commented 1 year ago

https://github.com/sidferreira/react-native-graph-tests

https://github.com/sidferreira/react-native-graph/tree/multiple-graphs

What I tried to do is to create a shared const panGesture = usePanGesture({holdDuration: 100}); that is an argument for the graph, and then you can have a main graph and all others (using pointerEvents="none") will follow it

@youssdevx @mrousavy

sidferreira commented 1 year ago

I also tried to make the graph generic type

youssdevx commented 1 year ago

I'll look into it, many thanks 🙏🏽

sidferreira commented 1 year ago

@youssdevx https://github.com/margelo/react-native-graph/pull/66 too

youssdevx commented 1 year ago

I still did have the chance to work on this... @mrousavy do you have plans for this feature?

youssdevx commented 1 year ago

FYI, the new version of Victory has multiple lines, area charts... => https://github.com/FormidableLabs/victory-native-xl