margelo / react-native-graph

📈 Beautiful, high-performance Graphs and Charts for React Native built with Skia
https://margelo.io
MIT License
2.08k stars 118 forks source link

feat: update react-native-skia to 0.1.136 #31

Closed akinncar closed 2 years ago

akinncar commented 2 years ago

Upgrades:

Changes:

Comments

I can't solve this types validation, seems to work for me as expected with @ts-ignore but please help me to solve it, I don't know how this works

Type 'SkiaValue<SkPath | null>' is not assignable to type 'PathDef | SkiaValue<PathDef>'.
  Type 'SkiaValue<SkPath | null>' is not assignable to type 'SkiaValue<PathDef>'.
    Type 'SkPath | null' is not assignable to type 'PathDef'.
      Type 'null' is not assignable to type 'PathDef'.ts(2322)

https://github.com/margelo/react-native-graph/compare/main...akinncar:feat/update-skia?expand=1#diff-cfb3f852e9829282d769b73218a60d92f55779488387a3333b1c5717365419e9R246

mrousavy commented 2 years ago

Does the point still move correctly with this PR?

I'm seeing this:

https://user-images.githubusercontent.com/15199031/179955118-2f846f5f-9ac0-4e07-91dd-b676b9c6d596.mov

gtokman commented 2 years ago

@mrousavy Someone filed an issue for that here https://github.com/margelo/react-native-graph/issues/26#issuecomment-1169147033

akinncar commented 2 years ago

Does the point still move correctly with this PR?

Fixed on latest commit

but a comment about it: on the first press on the graph, the circle starts in last position, so if is your first press after opening the app, the point will show on 0/0 It's not related to this PR since it's happening on main branch as well https://user-images.githubusercontent.com/42688281/180664840-8ae6c55c-6523-4f30-abe7-fdb596c3e109.mp4

UPDATE:

Fixed here https://github.com/margelo/react-native-graph/pull/32

mrousavy commented 2 years ago

Awesome, thank you Akinn! ❤️

HasanBingolbali commented 2 years ago

is it now fully compatible with react-native-Skia 0.1.136? @mrousavy @akinncar