Closed akinncar closed 2 years ago
Does the point still move correctly with this PR?
I'm seeing this:
@mrousavy Someone filed an issue for that here https://github.com/margelo/react-native-graph/issues/26#issuecomment-1169147033
Does the point still move correctly with this PR?
Fixed on latest commit
but a comment about it: on the first press on the graph, the circle starts in last position, so if is your first press after opening the app, the point will show on 0/0 It's not related to this PR since it's happening on main branch as well https://user-images.githubusercontent.com/42688281/180664840-8ae6c55c-6523-4f30-abe7-fdb596c3e109.mp4
Fixed here https://github.com/margelo/react-native-graph/pull/32
Awesome, thank you Akinn! ❤️
is it now fully compatible with react-native-Skia 0.1.136? @mrousavy @akinncar
Upgrades:
Changes:
Comments
I can't solve this types validation, seems to work for me as expected with
@ts-ignore
but please help me to solve it, I don't know how this workshttps://github.com/margelo/react-native-graph/compare/main...akinncar:feat/update-skia?expand=1#diff-cfb3f852e9829282d769b73218a60d92f55779488387a3333b1c5717365419e9R246