search

margelo / react-native-graph

📈 Beautiful, high-performance Graphs and Charts for React Native built with Skia
https://margelo.io
MIT License
2.08k stars 118 forks source link

Feat/support skia v0.1.233 #96

Closed sunrise1002 closed 8 months ago

sunrise1002 commented 9 months ago

Support skia v0.1.233

gabimoncha commented 9 months ago

@sunrise1002 I would decrease the version to 0.1.221 since this is the one supported by expo too.

daxaxelrod commented 9 months ago

I guess I should have checked before I went and did the same thing haha https://github.com/margelo/react-native-graph/pull/99

const paths = useSharedValue<{ ...

seems to be giving me a bit of trouble, getting host object errors

gabimoncha commented 8 months ago

@mrousavy @chrispader - I confirm this PR fixes the graph with the latest Skia version 0.1.241 The latest version will make the graph compatible with Expo and Expo web

mrousavy commented 8 months ago

I'll take a look in a few hours!

mrousavy commented 8 months ago

Looks good! I think we can bump even further to latest, lgtm

dsshard commented 8 months ago

@mrousavy Hello! Will it be possible to make a new version in npm?

mrousavy commented 8 months ago

Sure - done!