search

margelo / react-native-quick-crypto

⚡️ A fast implementation of Node's `crypto` module written in C/C++ JSI
Other
651 stars 82 forks source link

[Suggestion] Use latest `ndkports` for the OpenSSL library of Android #351

Open wh201906 opened 3 weeks ago

wh201906 commented 3 weeks ago

Hi there. It looks like the OpenSSL library for Android of react-native-quick-crypto is from this site. But the latest AAR on it was released on Oct 18, 2022 and is somewhat outdated. While the AAR on the Maven repo seems to be unmaintained, the source code of ndkports is actively updated on this site. Would it be possible for react-native-quick-crypto to build the latest OpenSSL for Android based on the latest source code of ndkports? I guess KDAB/android_openssl is also a good choice because it has been actively maintained. But it's for Qt on Android so I'm sure if it works for react-native-quick-crypto.

boorad commented 3 weeks ago

Want to throw together a PR with this change and see how the tests in the example application do with it?

wh201906 commented 3 weeks ago

I'm still getting familiar with the codebase of this library. But I'd love to contribute if I could.

shamilovtim commented 2 weeks ago

I went ahead and opened an issue on this: https://github.com/android/ndk-samples/issues/1068