Open compojoom opened 1 month ago
@compojoom hey, thanks for the ticket!
This was commented out a while ago, and doesn't show as implemented here. However, I think it's a case of implementing importKey()
before generateKey()
which prevented the tests from being activated here.
If you want to try to uncomment everything, and make sure a test covers your use case (or add one), and submit a PR, that would be 👌 . If not, I can get to it soon.
What's happening?
I'm trying to work with passkeys. I'm generating a passkey with "react-native-passkeys" https://github.com/peterferguson/react-native-passkeys, then trying to extract the coordinates and rawId with the @safe-global/protocol-kit library: https://github.com/safe-global/safe-core-sdk/blob/main/packages/protocol-kit/src/utils/passkeys/extractPasskeyData.ts#L12
Then the code fails on this line: https://github.com/safe-global/safe-core-sdk/blob/main/packages/protocol-kit/src/utils/passkeys/extractPasskeyData.ts#L47 with "Unknown EC import format: spki"
I can see in the source code that that spki import case has been disabled: https://github.com/margelo/react-native-quick-crypto/blob/0.x/src/ec.ts#L146
Why?
Reproducible Code
Relevant log output
Device
simulator iPhone Pro 16 (ios 18)
QuickCrypto Version
0.7.5
Can you reproduce this issue in the QuickCrypto Example app?
I didn't try (⚠️ your issue might get ignored & closed if you don't try this)
Additional information