search

margelo / react-native-release-profiler

A fast and simple library to passively profile JS/Hermes performance in production and release builds.
https://margelo.io
MIT License
188 stars 2 forks source link

fix: remove direct dependency `@react-native-community/cli` #5

Closed szymonrybczak closed 1 week ago

szymonrybczak commented 2 weeks ago

Hey!

In general tools/libraries shouldn't depend on @react-native-community/cli, it can cause hard to debug problems like this one, where react-native-release-profiler overrides CLI version and breaks autolinking 😅

Also CLI parts that are used here were recently removed from CLI - https://github.com/react-native-community/cli/pull/2316. So to keep this tool updated and compatible with most recent React Native versions we need to fork some parts of codebase .

After my changes tool should work in the same way as before.

hannojg commented 2 weeks ago

Will take a look later today!

kirillzyusko commented 1 week ago

After minor code changes I can confirm, that everything works as before:

Android iOS
image image
szymonrybczak commented 1 week ago

Btw, are you be able to release it? 🙏

kirillzyusko commented 1 week ago

@szymonrybczak I think we want to merge several other PRs and then prepare a new release 👀