margelo / react-native-skottie

▶️ Efficient lottie animations using Skia's Skottie module
https://margelo.io
MIT License
868 stars 24 forks source link

'RNSkiaModule.h' file not found with <angled> include; use "quotes" instead #25

Closed mmr94 closed 6 months ago

mmr94 commented 9 months ago

simple patch for ios native module

JimTeva commented 9 months ago

Same problem with version 2.1.0. This is strange because user @relaxxxpls encounters the same problem here but seems to get it work by installing the latest version... My setup is RN 0.72.7 on Xcode 15.2 and use_frameworks! in Podfile. If I correct the 4 errors related to include, then I get more than 100 errors after...

hannojg commented 9 months ago

Can anyone of you please provide a reproduction repository for that issue? Much appreciated, thanks! 😊

JimTeva commented 9 months ago

Here you are.

idrakimuhamad commented 9 months ago

I'm having this too in latest version. Downgraded to 2.0.4, also still have it. With Skia 0.1.230 and 0.1.237.

image
JimTeva commented 9 months ago

@hannojg any luck with the repo I provided?

hannojg commented 9 months ago

Hey, just checked your reproduction. The issue seems to arise due to the usage of use_frameworks. Will check if we can get that fixed 😊

JimTeva commented 9 months ago

use_frameworks is now mandatory if we want to use Firebase, so I need that. Thanks @hannojg

idrakimuhamad commented 9 months ago

I also use Firebase, so use_framework is needed unfortunately.

JimTeva commented 8 months ago

@hannojg is there any fix for use_frameworks?

roy-sandoval commented 8 months ago

I'm having the same issue and also use Firebase

exzos28 commented 8 months ago

@hannojg I've tried to fix it, but it looks like a linking problem because Firebase requires linkage static. Do you think we can use angled symbols for both situations?

hannojg commented 8 months ago

Is using angle brackets fixing the issue for you? When I tested it fixed this particular build error but then caused a bunch of others.

Is using react-native-skia with Firebase / use_frameworks possible?

exzos28 commented 8 months ago

@hannojg I'll test again and let you know

idrakimuhamad commented 8 months ago

https://github.com/Shopify/react-native-skia/issues/652#issuecomment-1280278930

Can anyone try this?

Seems already in RNSkia since 183 i believe

JimTeva commented 8 months ago

https://github.com/Shopify/react-native-skia/issues/652#issuecomment-1280278930

Can anyone try this?

Seems already in RNSkia since 183 i believe

It is actually the only workaround at the moment if you want to install react native skia, I've already provided the repository to try here https://github.com/margelo/react-native-skottie/issues/25#issuecomment-1920911653

JimTeva commented 8 months ago

@hannojg Yes the workaround that @idrakimuhamad mentionned is the one that allows to install skia without errors. The podfile I gave you already includes this workaround

idrakimuhamad commented 8 months ago

Yeah i think we don't actually need the workaround as it's already being part of the pod-spec now(?)

https://github.com/Shopify/react-native-skia/pull/1400

JimTeva commented 8 months ago

@idrakimuhamad I've tried without it and it doesn't work but maybe I did something wrong. Please make a new project and install react native skia and if it works then provide a repository for us thanks

idrakimuhamad commented 8 months ago

Chill. What I meant is that, because i'm using firebase and also Skia in my codebase. I do not have issue when installing Skia nor when building the app, so I did not use the workaround. I only get this error when building the app once skottie are being added.

thoth-seshat commented 8 months ago

I'm also running into this same issue: Running expo:

"@shopify/react-native-skia": "0.1.241",
"expo": "50.0.8",
"react-native-skottie": "^2.1.0",
...

I'll have to fall back to lottie-react-native until I can upgrade to skottie when this is resolved. If anyone is working on it, LMK if you need anymore info. I don't have bandwidth to attempt to find the issue at the moment but can't help test or give feedback.

Screenshot 2024-03-04 at 10 49 14 PM
themtaysw commented 7 months ago

Screenshot 2024-03-11 at 22 15 23 xdddd

themtaysw commented 7 months ago

i mean... this error is here for a good moment now, did they abandon the project or what xdd

JimTeva commented 7 months ago

@hannojg 🥺

ejkkan commented 7 months ago

Also seeing this. Would be great with a fix asap!

amrathhugo commented 6 months ago

Can someone help with any workaround for this issue for now? Thanks

kadiraydinli commented 6 months ago

Is there any progress on this issue?

hannojg commented 6 months ago

Should be fixed in version https://github.com/margelo/react-native-skottie/releases/tag/v2.1.1

idrakimuhamad commented 6 months ago

Thanks. I'm able to build the app as of v2.1.1, though I'm getting some other crashes related to my lottie file. I will open another ticket.

JimTeva commented 6 months ago

Thank you very much @hannojg (building ok with React-native@0.72.6 + @shopify/react-native-skia@1.2.3 and react-native-skottie@2.1.4 - I mentionned this because updating skia was very important also)