search

margelo / react-native-skottie

▶️ Efficient lottie animations using Skia's Skottie module
https://margelo.io
MIT License
868 stars 24 forks source link

Build error using rnskia > 1.x.x #28

Closed tanlucvo closed 6 months ago

tanlucvo commented 7 months ago

Thanks for awesome library, i got crash when use skottie

import LottieAnimationFile from 'assets/lottie/loading.json';
import { Skottie } from 'react-native-skottie';

import React from 'react';

const Loading = () => {
  return (
    <Skottie
      source={LottieAnimationFile}
      style={{ width: 100, height: 100 }}
      autoPlay
      loop
    />
  );
};

export default Loading;

Version 

"@shopify/react-native-skia": "^1.0.3",
"react-native-skottie": "^2.1.0",
vajidbb commented 7 months ago

@tanlucvo did you fixed the issue? I am getting crash with @shopify/react-native-skia": "^1.0.3" react-native-skottie: "^2.1.0"

tanlucvo commented 7 months ago

@tanlucvo did you fixed the issue? I am getting crash with @shopify/react-native-skia": "^1.0.3" react-native-skottie: "^2.1.0"

On IOS still working, but Android i got issue fatal error: 'ReactCommon/RuntimeExecutor.h' file not found

bricezele commented 7 months ago

Got same error @tanlucvo

hannojg commented 7 months ago

Which react native versions are you using? I think this issue appears with the latest version 0.73.X

tanlucvo commented 7 months ago

Which react native versions are you using? I think this issue appears with the latest version 0.73.X

I using latest RN "react-native": "0.73.6"

nikhilyadavvvv commented 7 months ago

I got following logs when crash occurs in xcode

Installing JSI bindings for react-native-skottie...
Successfully installed JSI bindings for react-native-skottie!
Assertion failed: (_type == JsiWrapperValueType::Bool), function getAsBool, file JsiValueWrapper.h, line 95.
mkyukov commented 7 months ago

@tanlucvo did you fixed the issue? I am getting crash with @shopify/react-native-skia": "^1.0.3" react-native-skottie: "^2.1.0"

On IOS still working, but Android i got issue fatal error: 'ReactCommon/RuntimeExecutor.h' file not found

@hannojg I am getting the same error when building for Android - running on an M1 MacBook Pro if that is relevant. I've tried running ./gradlew clean and cleaning up node_modules + reinstalling the packages.

Relevant package versions:

Error log: 

> Task :react-native-skottie:buildCMakeDebug[arm64-v8a] FAILED
C/C++: ninja: Entering directory `/Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/react-native-skottie/android/.cxx/Debug/55h5d3s1/arm64-v8a'
C/C++: In file included from /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/react-native-skottie/android/cpp/jni/JniLoad.cpp:1:
C/C++: In file included from /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/react-native-skottie/android/cpp/jni/include/JniSkiaSkottieView.h:10:
C/C++: In file included from /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/@shopify/react-native-skia/android/build/headers/rnskia/JniSkiaBaseView.h:10:
C/C++: In file included from /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/@shopify/react-native-skia/android/build/headers/rnskia/JniSkiaManager.h:8:
C/C++: /Users/<REDACTED>/.gradle/caches/transforms-3/5c9dce5e4efb5da58fd43ed81254dd1e/transformed/jetified-react-android-0.72.6-debug/prefab/modules/react_nativemodule_core/include/react/jni/JRuntimeExecutor.h:10:10: fatal error: 'ReactCommon/RuntimeExecutor.h' file not found
C/C++: In file included from /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/react-native-skottie/cpp/react-native-skia-skottie.cpp:2:
C/C++: In file included from /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/react-native-skottie/android/../cpp/JsiSkSkottie.h:5:
C/C++: In file included from /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/@shopify/react-native-skia/cpp/api/JsiSkCanvas.h:9:
C/C++: In file included from /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/@shopify/react-native-skia/cpp/api/JsiSkImage.h:9:
C/C++: /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/@shopify/react-native-skia/cpp/api/JsiSkMatrix.h:130:21: warning: 'RNSkia::JsiSkMatrix::get' hides overloaded virtual function [-Woverloaded-virtual]
C/C++: /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/@shopify/react-native-skia/cpp/jsi/JsiHostObject.h:153:14: note: hidden overloaded virtual function 'RNJsi::JsiHostObject::get' declared here: different number of parameters (2 vs 4)
C/C++: In file included from /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/react-native-skottie/cpp/react-native-skia-skottie.cpp:2:
C/C++: In file included from /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/react-native-skottie/android/../cpp/JsiSkSkottie.h:5:
C/C++: In file included from /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/@shopify/react-native-skia/cpp/api/JsiSkCanvas.h:9:
C/C++: /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/@shopify/react-native-skia/cpp/api/JsiSkImage.h:180:12: warning: moving a local object in a return statement prevents copy elision [-Wpessimizing-move]
C/C++: /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/@shopify/react-native-skia/cpp/api/JsiSkImage.h:180:12: note: remove std::move call here
C/C++: In file included from /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/react-native-skottie/cpp/react-native-skia-skottie.cpp:2:
C/C++: In file included from /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/react-native-skottie/android/../cpp/JsiSkSkottie.h:5:
C/C++: In file included from /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/@shopify/react-native-skia/cpp/api/JsiSkCanvas.h:17:
C/C++: /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/@shopify/react-native-skia/cpp/api/JsiSkRSXform.h:43:21: warning: 'RNSkia::JsiSkRSXform::set' hides overloaded virtual function [-Woverloaded-virtual]
C/C++: /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/@shopify/react-native-skia/cpp/jsi/JsiHostObject.h:143:8: note: hidden overloaded virtual function 'RNJsi::JsiHostObject::set' declared here: different number of parameters (3 vs 4)
C/C++: In file included from /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/react-native-skottie/cpp/react-native-skia-skottie.cpp:1:
C/C++: /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/react-native-skottie/android/../cpp/react-native-skia-skottie.h:20:17: warning: private field '_jsRuntime' is not used [-Wunused-private-field]

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/8.0.1/userguide/command_line_interface.html#sec:command_line_warnings
947 actionable tasks: 941 executed, 6 up-to-date

info 💡 Tip: Make sure that you have set up your development environment correctly, by running react-native doctor. To read more about doctor command visit: https://github.com/react-native-community/cli/blob/main/packages/cli-doctor/README.md#doctor 

Note: /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/@react-native-async-storage/async-storage/android/src/main/java/com/reactnativecommunity/asyncstorage/AsyncStorageModule.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/@react-native-async-storage/async-storage/android/src/main/java/com/reactnativecommunity/asyncstorage/AsyncStoragePackage.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/@react-native-community/slider/android/src/oldarch/java/com/reactnativecommunity/slider/ReactSliderManager.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Note: /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/@react-native-cookies/cookies/android/src/main/java/com/reactnativecommunity/cookies/CookieManagerModule.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Note: /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/@shopify/react-native-skia/android/src/main/java/com/shopify/reactnative/skia/ViewScreenshotService.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Note: /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/react-native-svg/android/src/main/java/com/horcrux/svg/VirtualView.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/react-native-video/android/src/main/java/com/brentvatne/react/ReactVideoViewManager.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Note: /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/@sentry/react-native/android/src/main/java/io/sentry/react/RNSentryModuleImpl.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/@snowplow/react-native-tracker/android/src/main/java/com/snowplowanalytics/react/util/ConfigUtil.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Note: /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/node_modules/.pnpm/expo-secure-store@12.3.1_expo@49.0.9/node_modules/expo-secure-store/android/src/main/java/expo/modules/securestore/SecureStoreModule.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':react-native-skottie:buildCMakeDebug[arm64-v8a]'.
> com.android.ide.common.process.ProcessException: ninja: Entering directory `/Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/react-native-skottie/android/.cxx/Debug/55h5d3s1/arm64-v8a'
  [1/5] Building CXX object CMakeFiles/react-native-skottie.dir/Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/react-native-skottie/cpp/RNSkTime.cpp.o
  [2/5] Building CXX object CMakeFiles/react-native-skottie.dir/cpp-adapter.cpp.o
  [3/5] Building CXX object CMakeFiles/react-native-skottie.dir/cpp/jni/JniLoad.cpp.o
  FAILED: CMakeFiles/react-native-skottie.dir/cpp/jni/JniLoad.cpp.o 
  /Users/<REDACTED>/Library/Android/sdk/ndk/23.1.7779620/toolchains/llvm/prebuilt/darwin-x86_64/bin/clang++ --target=aarch64-none-linux-android26 --sysroot=/Users/<REDACTED>/Library/Android/sdk/ndk/23.1.7779620/toolchains/llvm/prebuilt/darwin-x86_64/sysroot -Dreact_native_skottie_EXPORTS -I/Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/react-native-skottie/android/../cpp -I/Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/react-native-skottie/android/cpp/jni/include -I/Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/react-native/ReactCommon/callinvoker -I/Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/react-native/ReactCommon/jsi -I/Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/react-native/ReactCommon -I/Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/react-native/ReactCommon/react/nativemodule/core -I/Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/react-native/ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/jni -I/Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/@shopify/react-native-skia/cpp/rnskia -I/Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/@shopify/react-native-skia/cpp/skia/include/config -I/Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/@shopify/react-native-skia/cpp/skia/include/core -I/Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/@shopify/react-native-skia/cpp/skia/include/effects -I/Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/@shopify/react-native-skia/cpp/skia/include/utils -I/Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/@shopify/react-native-skia/cpp/skia/include/pathops -I/Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/@shopify/react-native-skia/cpp/skia/modules -I/Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/@shopify/react-native-skia/cpp/skia/modules/skparagraph/include -I/Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/@shopify/react-native-skia/cpp/skia/include -I/Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/@shopify/react-native-skia/cpp/skia -I/Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/@shopify/react-native-skia/cpp/api -I/Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/@shopify/react-native-skia/cpp/jsi -I/Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/@shopify/react-native-skia/cpp/rnskia/values -I/Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/@shopify/react-native-skia/cpp/rnskia/dom -I/Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/@shopify/react-native-skia/cpp/rnskia/dom/base -I/Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/@shopify/react-native-skia/cpp/rnskia/dom/nodes -I/Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/@shopify/react-native-skia/cpp/rnskia/dom/props -I/Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/@shopify/react-native-skia/cpp/utils -isystem /Users/<REDACTED>/.gradle/caches/transforms-3/b1b4a35365af2686094eaa92a126fbd5/transformed/jetified-fbjni-0.3.0/prefab/modules/fbjni/include -isystem /Users/<REDACTED>/.gradle/caches/transforms-3/5c9dce5e4efb5da58fd43ed81254dd1e/transformed/jetified-react-android-0.72.6-debug/prefab/modules/react_nativemodule_core/include -isystem /Users/<REDACTED>/.gradle/caches/transforms-3/5c9dce5e4efb5da58fd43ed81254dd1e/transformed/jetified-react-android-0.72.6-debug/prefab/modules/jsi/include -isystem /Users/<REDACTED>/.gradle/caches/transforms-3/5c9dce5e4efb5da58fd43ed81254dd1e/transformed/jetified-react-android-0.72.6-debug/prefab/modules/turbomodulejsijni/include -isystem /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/@shopify/react-native-skia/android/build/headers/rnskia -O2 -frtti -fexceptions -Wall -Wno-unused-variable -fstack-protector-all -g  -fno-limit-debug-info -fPIC -std=gnu++17 -MD -MT CMakeFiles/react-native-skottie.dir/cpp/jni/JniLoad.cpp.o -MF CMakeFiles/react-native-skottie.dir/cpp/jni/JniLoad.cpp.o.d -o CMakeFiles/react-native-skottie.dir/cpp/jni/JniLoad.cpp.o -c /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/react-native-skottie/android/cpp/jni/JniLoad.cpp
  In file included from /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/react-native-skottie/android/cpp/jni/JniLoad.cpp:1:
  In file included from /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/react-native-skottie/android/cpp/jni/include/JniSkiaSkottieView.h:10:
  In file included from /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/@shopify/react-native-skia/android/build/headers/rnskia/JniSkiaBaseView.h:10:
  In file included from /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/@shopify/react-native-skia/android/build/headers/rnskia/JniSkiaManager.h:8:
  /Users/<REDACTED>/.gradle/caches/transforms-3/5c9dce5e4efb5da58fd43ed81254dd1e/transformed/jetified-react-android-0.72.6-debug/prefab/modules/react_nativemodule_core/include/react/jni/JRuntimeExecutor.h:10:10: fatal error: 'ReactCommon/RuntimeExecutor.h' file not found
  #include <ReactCommon/RuntimeExecutor.h>
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  1 error generated.
  [4/5] Building CXX object CMakeFiles/react-native-skottie.dir/Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/react-native-skottie/cpp/react-native-skia-skottie.cpp.o
  In file included from /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/react-native-skottie/cpp/react-native-skia-skottie.cpp:2:
  In file included from /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/react-native-skottie/android/../cpp/JsiSkSkottie.h:5:
  In file included from /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/@shopify/react-native-skia/cpp/api/JsiSkCanvas.h:9:
  In file included from /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/@shopify/react-native-skia/cpp/api/JsiSkImage.h:9:
  /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/@shopify/react-native-skia/cpp/api/JsiSkMatrix.h:130:21: warning: 'RNSkia::JsiSkMatrix::get' hides overloaded virtual function [-Woverloaded-virtual]
    JSI_HOST_FUNCTION(get) {
                      ^
  /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/@shopify/react-native-skia/cpp/jsi/JsiHostObject.h:153:14: note: hidden overloaded virtual function 'RNJsi::JsiHostObject::get' declared here: different number of parameters (2 vs 4)
    jsi::Value get(jsi::Runtime &runtime, const jsi::PropNameID &name) override;
               ^
  In file included from /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/react-native-skottie/cpp/react-native-skia-skottie.cpp:2:
  In file included from /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/react-native-skottie/android/../cpp/JsiSkSkottie.h:5:
  In file included from /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/@shopify/react-native-skia/cpp/api/JsiSkCanvas.h:9:
  /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/@shopify/react-native-skia/cpp/api/JsiSkImage.h:180:12: warning: moving a local object in a return statement prevents copy elision [-Wpessimizing-move]
      return std::move(dest);
             ^
  /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/@shopify/react-native-skia/cpp/api/JsiSkImage.h:180:12: note: remove std::move call here
      return std::move(dest);
             ^~~~~~~~~~    ~
  In file included from /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/react-native-skottie/cpp/react-native-skia-skottie.cpp:2:
  In file included from /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/react-native-skottie/android/../cpp/JsiSkSkottie.h:5:
  In file included from /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/@shopify/react-native-skia/cpp/api/JsiSkCanvas.h:17:
  /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/@shopify/react-native-skia/cpp/api/JsiSkRSXform.h:43:21: warning: 'RNSkia::JsiSkRSXform::set' hides overloaded virtual function [-Woverloaded-virtual]
    JSI_HOST_FUNCTION(set) {
                      ^
  /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/@shopify/react-native-skia/cpp/jsi/JsiHostObject.h:143:8: note: hidden overloaded virtual function 'RNJsi::JsiHostObject::set' declared here: different number of parameters (3 vs 4)
    void set(jsi::Runtime &rt, const jsi::PropNameID &name,
         ^
  In file included from /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/react-native-skottie/cpp/react-native-skia-skottie.cpp:1:
  /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/react-native-skottie/android/../cpp/react-native-skia-skottie.h:20:17: warning: private field '_jsRuntime' is not used [-Wunused-private-field]
    jsi::Runtime* _jsRuntime;
                  ^
  4 warnings generated.
  ninja: build stopped: subcommand failed.

  C++ build system [build] failed while executing:
      /Users/<REDACTED>/Library/Android/sdk/cmake/3.22.1/bin/ninja \
        -C \
        /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/react-native-skottie/android/.cxx/Debug/55h5d3s1/arm64-v8a \
        react-native-skottie
    from /Users/<REDACTED>/Projects/<REDACTED>/<REDACTED>/<REDACTED>/apps/lake/node_modules/react-native-skottie/android

Let me know if you need additional info.

RyuWoong commented 7 months ago

any solution?

my library versions

    "react-native": "0.73.6",
    "react-native-skottie": "^2.1.0",
    "@shopify/react-native-skia": "^1.0.4",
purrsong-chong commented 7 months ago

got same error @mkyukov

"react-native-skottie": "2.1.0" "react-native": "0.72.3" "@shopify/react-native-skia": "^1.0.4"

elsa17z commented 6 months ago

Same here, only an issue on Android, no issue on iOS "react": "18.2.0", "react-native": "0.73.6", "@shopify/react-native-skia": "^1.2.0", "react-native-skottie": "^2.1.0",

Wed, 17 Apr 2024 13:10:27 GMT

[stderr]

FAILURE: Build failed with an exception. Wed, 17 Apr 2024 13:10:27 GMT

[stderr]

  • What went wrong: Wed, 17 Apr 2024 13:10:27 GMT

[stderr]

Execution failed for task ':react-native-skottie:buildCMakeDebug[arm64-v8a]'. Wed, 17 Apr 2024 13:10:27 GMT

[stderr]

com.android.ide.common.process.ProcessException: ninja: Entering directory `/home/expo/workingdir/build/node_modules/react-native-skottie/android/.cxx/Debug/4tp386h2/arm64-v8a' Wed, 17 Apr 2024 13:10:27 GMT

[stderr]

[1/5] Building CXX object CMakeFiles/react-native-skottie.dir/home/expo/workingdir/build/node_modules/react-native-skottie/cpp/RNSkTime.cpp.o Wed, 17 Apr 2024 13:10:27 GMT

[stderr]

[2/5] Building CXX object CMakeFiles/react-native-skottie.dir/cpp-adapter.cpp.o Wed, 17 Apr 2024 13:10:27 GMT

[stderr]

[3/5] Building CXX object CMakeFiles/react-native-skottie.dir/cpp/jni/JniLoad.cpp.o Wed, 17 Apr 2024 13:10:27 GMT

[stderr]

FAILED: CMakeFiles/react-native-skottie.dir/cpp/jni/JniLoad.cpp.o Wed, 17 Apr 2024 13:10:27 GMT

[stderr]

/home/expo/Android/Sdk/ndk/25.1.8937393/toolchains/llvm/prebuilt/linux-x86_64/bin/clang++ --target=aarch64-none-linux-android23 --sysroot=/home/expo/Android/Sdk/ndk/25.1.8937393/toolchains/llvm/prebuilt/linux-x86_64/sysroot -Dreact_native_skottie_EXPORTS -I/home/expo/workingdir/build/node_modules/react-native-skottie/android/../cpp -I/home/expo/workingdir/build/node_modules/react-native-skottie/android/cpp/jni/include -I/home/expo/workingdir/build/node_modules/react-native/ReactCommon/callinvoker -I/home/expo/workingdir/build/node_modules/react-native/ReactCommon/jsi -I/home/expo/workingdir/build/node_modules/react-native/ReactCommon -I/home/expo/workingdir/build/node_modules/react-native/ReactCommon/react/nativemodule/core -I/home/expo/workingdir/build/node_modules/react-native/ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/jni -I/home/expo/workingdir/build/node_modules/@shopify/react-native-skia/cpp/rnskia -I/home/expo/workingdir/build/node_modules/@shopify/react-native-skia/cpp/skia/include/config -I/home/expo/workingdir/build/node_modules/@shopify/react-native-skia/cpp/skia/include/core -I/home/expo/workingdir/build/node_modules/@shopify/react-native-skia/cpp/skia/include/effects -I/home/expo/workingdir/build/node_modules/@shopify/react-native-skia/cpp/skia/include/utils -I/home/expo/workingdir/build/node_modules/@shopify/react-native-skia/cpp/skia/include/pathops -I/home/expo/workingdir/build/node_modules/@shopify/react-native-skia/cpp/skia/modules -I/home/expo/workingdir/build/node_modules/@shopify/react-native-skia/cpp/skia/modules/skparagraph/include -I/home/expo/workingdir/build/node_modules/@shopify/react-native-skia/cpp/skia/include -I/home/expo/workingdir/build/node_modules/@shopify/react-native-skia/cpp/skia -I/home/expo/workingdir/build/node_modules/@shopify/react-native-skia/cpp/api -I/home/expo/workingdir/build/node_modules/@shopify/react-native-skia/cpp/jsi -I/home/expo/workingdir/build/node_modules/@shopify/react-native-skia/cpp/rnskia/values -I/home/expo/workingdir/build/node_modules/@shopify/react-native-skia/cpp/rnskia/dom -I/home/expo/workingdir/build/node_modules/@shopify/react-native-skia/cpp/rnskia/dom/base -I/home/expo/workingdir/build/node_modules/@shopify/react-native-skia/cpp/rnskia/dom/nodes -I/home/expo/workingdir/build/node_modules/@shopify/react-native-skia/cpp/rnskia/dom/props -I/home/expo/workingdir/build/node_modules/@shopify/react-native-skia/cpp/utils -isystem /home/expo/.gradle/caches/transforms-3/b270ed81273e9082a1970d58644ea579/transformed/jetified-fbjni-0.5.1/prefab/modules/fbjni/include -isystem /home/expo/.gradle/caches/transforms-3/f50a9afa12bd622b5f667fe0f6fad86c/transformed/jetified-react-android-0.73.6-debug/prefab/modules/react_nativemodule_core/include -isystem /home/expo/.gradle/caches/transforms-3/f50a9afa12bd622b5f667fe0f6fad86c/transformed/jetified-react-android-0.73.6-debug/prefab/modules/jsi/include -isystem /home/expo/.gradle/caches/transforms-3/f50a9afa12bd622b5f667fe0f6fad86c/transformed/jetified-react-android-0.73.6-debug/prefab/modules/turbomodulejsijni/include -isystem /home/expo/workingdir/build/node_modules/@shopify/react-native-skia/android/build/headers/rnskia -g -DANDROID -fdata-sections -ffunction-sections -funwind-tables -fstack-protector-strong -no-canonical-prefixes -D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security -O2 -frtti -fexceptions -Wall -Wno-unused-variable -fstack-protector-all -fno-limit-debug-info -fPIC -std=gnu++17 -MD -MT CMakeFiles/react-native-skottie.dir/cpp/jni/JniLoad.cpp.o -MF CMakeFiles/react-native-skottie.dir/cpp/jni/JniLoad.cpp.o.d -o CMakeFiles/react-native-skottie.dir/cpp/jni/JniLoad.cpp.o -c /home/expo/workingdir/build/node_modules/react-native-skottie/android/cpp/jni/JniLoad.cpp Wed, 17 Apr 2024 13:10:27 GMT

[stderr]

In file included from /home/expo/workingdir/build/node_modules/react-native-skottie/android/cpp/jni/JniLoad.cpp:1: Wed, 17 Apr 2024 13:10:27 GMT

[stderr]

/home/expo/workingdir/build/node_modules/react-native-skottie/android/cpp/jni/include/JniSkiaSkottieView.h:10:10: fatal error: 'JniSkiaBaseView.h' file not found Wed, 17 Apr 2024 13:10:27 GMT

[stderr]

include

Wed, 17 Apr 2024 13:10:27 GMT

[stderr]

Wed, 17 Apr 2024 13:10:27 GMT

[stderr]

1 error generated. Wed, 17 Apr 2024 13:10:27 GMT

[stderr]

[4/5] Building CXX object CMakeFiles/react-native-skottie.dir/home/expo/workingdir/build/node_modules/react-native-skottie/cpp/react-native-skia-skottie.cpp.o Wed, 17 Apr 2024 13:10:27 GMT

[stderr]

In file included from /home/expo/workingdir/build/node_modules/react-native-skottie/cpp/react-native-skia-skottie.cpp:2: Wed, 17 Apr 2024 13:10:27 GMT

[stderr]

In file included from /home/expo/workingdir/build/node_modules/react-native-skottie/android/../cpp/JsiSkSkottie.h:5: Wed, 17 Apr 2024 13:10:27 GMT

[stderr]

In file included from /home/expo/workingdir/build/node_modules/@shopify/react-native-skia/cpp/api/JsiSkCanvas.h:9: Wed, 17 Apr 2024 13:10:27 GMT

[stderr]

In file included from /home/expo/workingdir/build/node_modules/@shopify/react-native-skia/cpp/api/JsiSkImage.h:9: Wed, 17 Apr 2024 13:10:27 GMT

[stderr]

/home/expo/workingdir/build/node_modules/@shopify/react-native-skia/cpp/api/JsiSkMatrix.h:130:21: warning: 'RNSkia::JsiSkMatrix::get' hides overloaded virtual function [-Woverloaded-virtual] Wed, 17 Apr 2024 13:10:27 GMT

[stderr] 

JSI_HOST_FUNCTION(get) {

Wed, 17 Apr 2024 13:10:27 GMT

[stderr]

Wed, 17 Apr 2024 13:10:27 GMT

[stderr]

/home/expo/workingdir/build/node_modules/@shopify/react-native-skia/cpp/jsi/JsiHostObject.h:153:14: note: hidden overloaded virtual function 'RNJsi::JsiHostObject::get' declared here: different number of parameters (2 vs 4) Wed, 17 Apr 2024 13:10:27 GMT

[stderr] 

jsi::Value get(jsi::Runtime &runtime, const jsi::PropNameID &name) override;

Wed, 17 Apr 2024 13:10:27 GMT

[stderr] 

           ^

Wed, 17 Apr 2024 13:10:27 GMT

[stderr]

In file included from /home/expo/workingdir/build/node_modules/react-native-skottie/cpp/react-native-skia-skottie.cpp:2: Wed, 17 Apr 2024 13:10:27 GMT

[stderr]

In file included from /home/expo/workingdir/build/node_modules/react-native-skottie/android/../cpp/JsiSkSkottie.h:5: Wed, 17 Apr 2024 13:10:27 GMT

[stderr]

In file included from /home/expo/workingdir/build/node_modules/@shopify/react-native-skia/cpp/api/JsiSkCanvas.h:17: Wed, 17 Apr 2024 13:10:27 GMT

[stderr]

/home/expo/workingdir/build/node_modules/@shopify/react-native-skia/cpp/api/JsiSkRSXform.h:43:21: warning: 'RNSkia::JsiSkRSXform::set' hides overloaded virtual function [-Woverloaded-virtual] Wed, 17 Apr 2024 13:10:27 GMT

[stderr] 

JSI_HOST_FUNCTION(set) {

Wed, 17 Apr 2024 13:10:27 GMT

[stderr] 

                  ^

Wed, 17 Apr 2024 13:10:27 GMT

[stderr]

/home/expo/workingdir/build/node_modules/@shopify/react-native-skia/cpp/jsi/JsiHostObject.h:143:8: note: hidden overloaded virtual function 'RNJsi::JsiHostObject::set' declared here: different number of parameters (3 vs 4) Wed, 17 Apr 2024 13:10:27 GMT

[stderr] 

void set(jsi::Runtime &rt, const jsi::PropNameID &name,

Wed, 17 Apr 2024 13:10:27 GMT

[stderr] 

     ^

Wed, 17 Apr 2024 13:10:27 GMT

[stderr]

In file included from /home/expo/workingdir/build/node_modules/react-native-skottie/cpp/react-native-skia-skottie.cpp:1: Wed, 17 Apr 2024 13:10:27 GMT

[stderr]

/home/expo/workingdir/build/node_modules/react-native-skottie/android/../cpp/react-native-skia-skottie.h:20:17: warning: private field '_jsRuntime' is not used [-Wunused-private-field] Wed, 17 Apr 2024 13:10:27 GMT

[stderr] 

jsi::Runtime* _jsRuntime;

Wed, 17 Apr 2024 13:10:27 GMT

[stderr] 

              ^

Wed, 17 Apr 2024 13:10:27 GMT

[stderr]

3 warnings generated. Wed, 17 Apr 2024 13:10:27 GMT

[stderr]

ninja: build stopped: subcommand failed. Wed, 17 Apr 2024 13:10:27 GMT

[stderr]

Wed, 17 Apr 2024 13:10:27 GMT

[stderr]

C++ build system [build] failed while executing: Wed, 17 Apr 2024 13:10:27 GMT

[stderr] 

  /home/expo/Android/Sdk/cmake/3.22.1/bin/ninja \

Wed, 17 Apr 2024 13:10:27 GMT

[stderr] 

    -C \

Wed, 17 Apr 2024 13:10:27 GMT

[stderr] 

    /home/expo/workingdir/build/node_modules/react-native-skottie/android/.cxx/Debug/4tp386h2/arm64-v8a \

Wed, 17 Apr 2024 13:10:27 GMT

[stderr] 

    react-native-skottie

Wed, 17 Apr 2024 13:10:27 GMT

[stderr] 

from /home/expo/workingdir/build/node_modules/react-native-skottie/android

Wed, 17 Apr 2024 13:10:27 GMT

[stderr]

  • Try: Wed, 17 Apr 2024 13:10:27 GMT

[stderr]

Run with --stacktrace option to get the stack trace. Wed, 17 Apr 2024 13:10:27 GMT

[stderr]

Run with --info or --debug option to get more log output. Wed, 17 Apr 2024 13:10:27 GMT

[stderr]

Run with --scan to get full insights. Wed, 17 Apr 2024 13:10:27 GMT

[stderr]

Get more help at https://help.gradle.org. Wed, 17 Apr 2024 13:10:27 GMT

[stderr]

BUILD FAILED in 14m 16s

hannojg commented 6 months ago

Should be fixed in version https://github.com/margelo/react-native-skottie/releases/tag/v2.1.1