search

margro / xbmc

XBMC PVR Repository for the development of the MediaPortal and ForTheRecord pvr addons
http://www.scintilla.utwente.nl/~marcelg/xbmc/
Other
31 stars 14 forks source link

Duplicate "All Channels" Groups #17

Closed Meliorate closed 12 years ago

Meliorate commented 12 years ago

It's rather annoying to have to cycle through two sets of identical "all channels" groups for radio and tv, when selecting a different channel group. Ideally neither "all channels" groups would be visibie, but I assume that would need a change in xbmc-pvr, to give an option to "Hide" groups (would be a nice feature!). A quick interim fix to only show 1 "all channels" group for tv and radio would be to just skip the "all channels" group that is populated when it synchronises all groups with the backend, or is there some technical reason why both sets of "all channels" groups exist? I couldn't see one when I looked through the code...

margro commented 12 years ago

Well, it is slightly more complicated... The "All Channels" group belongs to XBMC-pvr (internal group) and the "All TV Channels" group is from the MePo TV Server. The internal group contains all channels from all backends (if you have more than one). I could skip the "All TV Channels" group from the MePo TV Server by adding a "Skip groups" option, but this has one problem at the moment. The internal "All Channels" group contains only a combined set of all channels from the imported groups, so when I skip the "All TV Channels" group and your other MePo groups contain together only a subset, you won't see all MePo backend channels in the XBMC "All Channels" group.

margro commented 12 years ago

Whoops, the "All TV Channels" and "All Radio Channels" groups is the internal groups in XBMC. The "All Channels" groups are from MediaPortal.

Meliorate commented 12 years ago

Yep, seems you had the internal XBMC and external MePo groups mixed up! I forked your repos and pushed a fix to it (see here: https://github.com/Meliorate/xbmc/tree/master/xbmc/pvrclients). It does not effect the internal XBMC group as this is pulled completely seperately. I'd apprecate if you could merge this fix with your repos...

margro commented 12 years ago

Just checked and tested your change. Doesn't break anything anymore because XBMC now always first requests the entire channel list (due to my own fix a few days back). Added a modified version of your changes. Thanks!

Meliorate commented 12 years ago

Great news! If you get time to hang around on #xbmc-pvr on the freenode IRC network, I would like to discuss some other issues I am experiencing with the MePo addon, which I would be keen to resolve, with some guidance from (or in collaboration with) you! I use the same nickname on freenode: Meliorate. If you say my name on the channel, my IRC client will alert me. I'm not always viewing the box which is running my IRC client, so I may not reply immediately. Hopefully I will catch you there soon.