Closed emoon closed 8 years ago
I actually tried that but I think I merged in the suba into my master and then based the branch on that so I will try to not do that the next time and see if that works better (only branch from master each time for each PR)
I think you should aim at getting the PRs independent of each other. This one was based on the commit/PR for SUBA. Fine and dandy if that PR is merged first, but complicates things if there's some issue with that commit.
But thank's for the PR anyway! Great that you are helping out!