search

marhel / r68k

A m68k emulator in rust - let r68k = musashi.clone();
MIT License
71 stars 7 forks source link

Implemented SHI #70

Closed emoon closed 8 years ago

emoon commented 8 years ago

Part of https://github.com/marhel/r68k/issues/45

marhel commented 8 years ago

Please add at least one test of the resulting op code constants. It will help if refactoring the "component constants" which I had to do today for the ASL constants, when trying to implement LSL, ROL and ROXL.

emoon commented 8 years ago

Will do!

emoon commented 8 years ago

Do you mean tests likes these ones? https://github.com/emoon/r68k/blob/master/src/cpu/ops/handlers.rs#L1860

marhel commented 8 years ago

For some reason I don't see the lineline numbers on the phone, but I mean tests like correctly_defined_op_eori_32_di, just copying Musashis constant, to verify our definition.

emoon commented 8 years ago

Will do a new one that merges clean