search

marhel / r68k

A m68k emulator in rust - let r68k = musashi.clone();
MIT License
72 stars 7 forks source link

Unlk opcode #78

Closed emoon closed 8 years ago

emoon commented 8 years ago

"Preview" of PR. This doesn't work for some reason. I had to add a pull_32 function also (similar to how it looks in Musashi) I wonder if you could just sanity check this code?

marhel commented 8 years ago

Cannot see anything obviously wrong when reviewing on my phone. Could you elaborate on "doesn't work", what do the qc-tests say?

marhel commented 8 years ago

BTW, I needed to add stack 16/32 bit pop operations as well, yesterday, as part of implementing the RTE instruction, so there'll be some merge issues, I guess.

emoon commented 8 years ago

Alright. I will just close this one, re-resolve with your changes and make a new PR. Thanks!