Implement better mapping between subtitle and media files when downloading

marhex / subcentral

Automatically exported from code.google.com/p/subcentral

0 stars 0 forks source link

Implement better mapping between subtitle and media files when downloading #37

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

Sometimes the download archive has subtitle for more than one release.
For example:
The site www.legendas.tv from Brazil very often offers the download of RAR 
files containing subtitles for several different releases of the same 
movie/episode. In the current implementation, this would cause the error: 
"Media files count differs from subtitle files count. Wrong subtitles?".

Then, based on the existing code, I created a patch to allow the user to select 
the desired subtitle file from a dialog.

I think this patch can be useful for other subtitle sources.

Original issue reported on code.google.com by juliano....@gmail.com on 15 Dec 2010 at 11:13

Attachments:

patch.diff

GoogleCodeExporter commented 9 years ago

Will take a closer look at the patch and commit it when I find some free time.

Thanks for improving SubCentral! :)

Original comment by mitja.skuver on 16 Dec 2010 at 4:03

Added labels: Milestone-1.0.0, Priority-High, Type-Enhancement

GoogleCodeExporter commented 9 years ago

Your patch errors out if there are 2 media files and more subtitle files. Will 
have to refactor it so we have everything supported :)

Original comment by mitja.skuver on 25 Jan 2011 at 3:55

Changed state: Started

GoogleCodeExporter commented 9 years ago

huummm, Ok...
Anyway, I haven't tested it thoroughly. Sorry!
Hope you can figure out a better way to handle this.
Thanks for the great work!

Changing a little the subject: I was very excited about this plugin, but one 
thing that turned me off a little is that Seco does not want to release the 
source code for his SubtitleDownloader library. What do you think about it?
I'm even thinking of writing a lib by myself and create a new project on Google 
Code...

Original comment by juliano....@gmail.com on 25 Jan 2011 at 4:22

GoogleCodeExporter commented 9 years ago

Okay, here we go. 
r160 if you wanna test it (would be good) :)

Sorry, I cannot speak for seco but it's his choice whether to publish source 
code or not. As long as it's well maintained and working (both true for 
SubtitleDownloader), I don't mind :)

Original comment by mitja.skuver on 25 Jan 2011 at 5:39

Changed title: Implement better mapping between subtitle and media files when downloading
Changed state: Fixed