search

marhoy / nrk-download

Download content from NRK, complete with images and subtitles:
https://nrkdownload.readthedocs.org
GNU General Public License v3.0
54 stars 10 forks source link

Wrong srt is downloaded #29

Closed balta2ar closed 2 years ago

balta2ar commented 2 years ago 
nrkdownload -d . 'https://tv.nrk.no/serie/kaass-til-kvelds/2022/MUHU17001022/avspiller'

This downloads a subtitle which is ~7.4K in size. The correct one for this episode is ~40K in size. After browsing network tab page I found this link for the correct srt: https://undertekst.nrk.no/MUHU17/00/MUHU17001022/TTV/MUHU17001022.vtt

nrkdownload version: 3.1.1
marhoy commented 2 years ago

Thanks for noticing!

Since one of the guests was Swedish, there was two sets of subtitles: One where only the Swedish was translated, and one where everything was texted.

I'm not only downloading the subtitle-file where defaultOn: True. The app still does not support programs where the program is too long and therefore split into multiple video- and subtitle-files. If you can find a good example of that, I can have a look at it.

Fixed in PR #30, merged in version 3.1.2.