Use subprocess instead of os.system for handling errors?

maria-antoniak / little-mallet-wrapper

A Python wrapper around the topic modeling functions of MALLET.

GNU General Public License v3.0

100 stars 17 forks source link

Use subprocess instead of os.system for handling errors? #2

Closed melaniewalsh closed 4 years ago

melaniewalsh commented 4 years ago

This is just a suggestion, but when I was messing around with Little MALLET wrapper in my Binder notebooks, I noticed that .import_data() and .train_topic_model() always report "Complete" even when Java is not installed or the MALLET path is wrong. So I was wondering if subprocess might be better than os.system for simple error reporting. However, if you capture the output with subprocess, then you can't see the topic model training on the command line...

maria-antoniak commented 4 years ago

Tried subprocess and went back to os because of the delay in output printing and errors on Windows.