maria-korosteleva / GarmentCode

A modular programming framework for designing parametric sewing patterns
MIT License
150 stars 15 forks source link

The order of stitching two edges #22

Closed hsiaoyu closed 2 weeks ago

hsiaoyu commented 2 weeks ago

Do you have any method for determining the correct stitching direction when combining two curves? The configuration only specifies which two curves should be stitched together, but it does not provide information on the direction of the stitching.

hsiaoyu commented 2 weeks ago

Pasting the response from the Maria. :)

In the most recent version of the JSON format (which is used in GarmentCodeData and PyGarment 2.0.0+), all the edges are expected to be stitched following the manifold property: a start vertex of one edge connects to the end vertex of the other edge, which creates the right side of fabric to right side of fabric connection.

There are exceptions, and they are marked with a "right_wrong" label in the stitch specification. If the mark is present you should use the other orientation (start to start). In our data, it's used for garments with lapels. Here is the core where we read this property: https://github.com/maria-korosteleva/GarmentCode/blob/5f20aec88ce126b96c847a2c6f8a65aa3a0eb875/pygarment/meshgen/boxmeshgen.py#L655