mariachris / Concuerror

Other
114 stars 20 forks source link

Bashism in concuerror command and command generation in the Makefile #7

Closed jj1bdx closed 10 years ago

jj1bdx commented 10 years ago

Please rewrite #!/bin/bash to #/usr/bin/env bash. This is a typical bashism and linuxism, which prevents Concuerror to run on FreeBSD.

I also find there is a hard-coded /bin/bash in the concuerror directive of Makefile. In FreeBSD this has to be /usr/local/bin/bash, but making this generating #/usr/bin/env bash. Without fixing this, concuerror didn't perform any meaningful test on FreeBSD amd64 10.0-STABLE R16B03-1.

I know I have to issue a pull-request for this, but just a quick notice FYI.

jj1bdx commented 10 years ago

Check PR #8. Closed.