updating Node.js engine support to Node.js v14

mariadb-corporation / mariadb-connector-nodejs

MariaDB Connector/Node.js is used to connect applications developed on Node.js to MariaDB and MySQL databases. MariaDB Connector/Node.js is LGPL licensed.

GNU Lesser General Public License v2.1

366 stars 91 forks source link

updating Node.js engine support to Node.js v14 #233

Closed tlhunter closed 1 year ago

tlhunter commented 1 year ago

version 3.1.0 of mariadb appears to break compatibility with Node.js v12
version 3.0.2 seems to not have the same syntax errors

Here's the output when I run the test suite with the latest Node.js v12 with 3.1.0:

/private/tmp/mariadb-connector-nodejs/lib/cmd/query.js:197
  #paramWritten(out, info) {
               ^

SyntaxError: Unexpected token '('

rusher commented 1 year ago

closing PR, since https://github.com/mariadb-corporation/mariadb-connector-nodejs/commit/e9d9a004bff2e98209531b29ae501efab987d2a1 will correct node.js 12 compatibility, removing the use of private instance methods, available with node.js 14.5 only