search

mariadb-corporation / mariadb-connector-nodejs

MariaDB Connector/Node.js is used to connect applications developed on Node.js to MariaDB and MySQL databases. MariaDB Connector/Node.js is LGPL licensed.
GNU Lesser General Public License v2.1
366 stars 91 forks source link

Sequelize delete property of meta object error #234

Open knoxcard2 opened 1 year ago

knoxcard2 commented 1 year ago

/etc/nginx/domains/buycanna.io/node_modules/sequelize/lib/dialects/mariadb/query.js:110

        delete data.meta;

TypeError: Cannot delete property 'meta' of [object Array] at Query.formatResults (/etc/nginx/domains/buycanna.io/node_modules/sequelize/lib/dialects/mariadb/query.js:110:7) at Query.run (/etc/nginx/domains/buycanna.io/node_modules/sequelize/lib/dialects/mariadb/query.js:73:17) at process.processTicksAndRejections (node:internal/process/task_queues:95:5) at async /etc/nginx/domains/buycanna.io/node_modules/sequelize/lib/sequelize.js:314:16

Node.js v19.6.1

PeppeL-G commented 1 year ago

This rather looks like a problem with the sequelize package?

WikiRik commented 1 year ago

It is, sequelize does not support v3 of this connector yet. Almost all tests of the sequelize package pass on 3.0.2 but more fail on 3.1.0 due to the non-enumerable meta. The advice of the sequelize team is to not upgrade to v3 of the mariadb connector until v7 of sequelize

rusher commented 1 year ago

do you have some link @WikiRik / @knoxcard2 ? correction is easy to do, and i can make a PR

WikiRik commented 1 year ago

do you have some link @WikiRik / @knoxcard2 ? correction is easy to do, and i can make a PR

You can check out which tests are failing in this renovate PR; https://github.com/sequelize/sequelize/pull/15311

rusher commented 1 year ago

from Rik Smale :

Starting with v7.0.0-alpha27 (released soon) sequelize will support 3.x. See https://github.com/sequelize/sequelize/pull/16139 Support for 3.x is not planned for sequelize v6 at this moment

WikiRik commented 1 year ago

Ah yes, I forgot this issue was open as well. Thanks for posting it here!

dcolley commented 1 year ago

Until v3 of the connector is supported:

npm install --save mariadb@2