search

mariadb-corporation / mariadb-connector-nodejs

MariaDB Connector/Node.js is used to connect applications developed on Node.js to MariaDB and MySQL databases. MariaDB Connector/Node.js is LGPL licensed.
GNU Lesser General Public License v2.1
369 stars 91 forks source link

Typescript: supportBigNumbers & bigNumberStrings missing in ConnectionConfig #240

Closed Nappsel closed 1 year ago

Nappsel commented 1 year ago

The ConnectConfig interface seems to be missing parameters supportBigNumbers and bigNumberStrings. According to the documentation they should be.

The following works, but is not covered by the TypeScript definition:

import { createConnection } from 'mariadb'

createConnection({
    host: '',
    database: '',
    user: '',
    password: '',
    supportBigNumbers: true,
  })
.then(() => {})
.catch(() => {});
rusher commented 1 year ago

right, even if deprecated, they are missing in Typescript definition.

rusher commented 1 year ago

Correction will be in 3.2.0 version