search

mariadb-corporation / mariadb-connector-nodejs

MariaDB Connector/Node.js is used to connect applications developed on Node.js to MariaDB and MySQL databases. MariaDB Connector/Node.js is LGPL licensed.
GNU Lesser General Public License v2.1
363 stars 93 forks source link

Add missing QueryOptions type to prepare function #279

Closed bc-m closed 3 months ago

bc-m commented 4 months ago

The types currently only allow strings as prepare parameter. The implementation and documentation looks like it supports query options as parameters.

Implementation:

https://github.com/mariadb-corporation/mariadb-connector-nodejs/blob/b65aca10b77f5ede83f16a8edd0537b2ef12a16f/lib/connection-promise.js#L119-L130

Documentation:

https://github.com/mariadb-corporation/mariadb-connector-nodejs/blob/b65aca10b77f5ede83f16a8edd0537b2ef12a16f/documentation/promise-api.md?plain=1#L991-L992

rusher commented 3 months ago

allright, thanks for PR, will be in 3.3.1