ConnectionPromise .close() function not in index.d.ts

mariadb-corporation / mariadb-connector-nodejs

MariaDB Connector/Node.js is used to connect applications developed on Node.js to MariaDB and MySQL databases. MariaDB Connector/Node.js is LGPL licensed.

GNU Lesser General Public License v2.1

378 stars 96 forks source link

ConnectionPromise .close() function not in index.d.ts #300

Open TonyGravagno opened 3 weeks ago

TonyGravagno commented 3 weeks ago

Examples show close function:
https://mariadb.com/docs/server/connect/programming-languages/nodejs/promise/example/

Close function is alias to .destroy() :
https://github.com/mariadb-corporation/mariadb-connector-nodejs/blob/24a58245cba201da91f41f7f96f8dd165d31c6c7/lib/connection-promise.js#L239

.close() is not in type definition:
https://github.com/mariadb-corporation/mariadb-connector-nodejs/blob/24a58245cba201da91f41f7f96f8dd165d31c6c7/types/index.d.ts#L625

v3.4.0

rusher commented 2 weeks ago

created https://jira.mariadb.org/browse/CONJS-305. will be part of 3.4.1