PingClass::_ping_recv_cb is not called

marian-craciunescu / ESP32Ping

Ping library for ESP32 Arduino core

GNU Lesser General Public License v2.1

110 stars 58 forks source link

PingClass::_ping_recv_cb is not called #6

Closed adynis closed 4 years ago

adynis commented 4 years ago

in ESP32Ping.cpp we have function PingClass::_ping_recv_cb(...) which should be able to get some statistics from the ping. The callback function is not called at all.

My proposal for ping.cpp:

modify the parameters of ping_start(IPAddress adr, ......) by adding also the ping_options structure which contains the pointer to the callback function
in the same ping_start(...) function: add a call of the callback function

adynis commented 4 years ago

Closing this, since it was resolved & merged