Failed to load story pack

MPR-Git commented 3 years ago

When editing the official pack "Les incollables CE2" I have an error : "Failed to load the pack" It does work for others pack

No logs appear on the consol, no error.

Desktop and environment (please complete the following information):

OS: Win 10 x64
Browser Edge/89.0.774.63
Java version: JDK 11.0.6
Maven version: 3.6.0
STUdio application version: 0.3.0-beta.2

Sorry, i can't tell more.

vpoulailleau commented 3 years ago

Same here, with some other official packs. The packs that I can't load are the ones with many transitions and steps. Are there any limitations in STUdio regarding the number of elements?

marian-m12l commented 3 years ago

@MPR-Git @vpoulailleau Did you check the browser's console for errors? It could be an edge case that I did not yet come across.

vpoulailleau commented 3 years ago

@marian-m12l Here is the error in the browser's console for Les incollables grande section de maternelle:

failed to load story pack TypeError: t.okPort is undefined
    ge reader.js:258
    ge reader.js:256
    promise callback*ge/< reader.js:24
    promise callback*ge reader.js:22
    Be index.js:367
    r Redux
    loadPackInEditor PackLibrary.js:465
    onEditLibraryPack PackLibrary.js:216
    promise callback*A/n.onEditLibraryPack/< PackLibrary.js:214
    React 12
        p
        p
        g
        g
        at
        it
        st
        dt
        j
        F
        Xt
        Zt
    unstable_runWithPriority scheduler.production.min.js:309
    React 3
        Hi
        I
        r
index.js:376:24
    Be index.js:376
    (Asynchrone : promise callback)
    Be index.js:375
    r Redux
    loadPackInEditor PackLibrary.js:465
    onEditLibraryPack PackLibrary.js:216
    (Asynchrone : promise callback)
    onEditLibraryPack PackLibrary.js:214
    React 12
        p
        p
        g
        g
        at
        it
        st
        dt
        j
        F
        Xt
        Zt
    unstable_runWithPriority scheduler.production.min.js:309
    React 3
        Hi
        I
        r

This is with beta 2, I haven't tested yet the beta 3.

EDIT: same with beta 3.

vpoulailleau commented 3 years ago

And with Les comptines pour danser, I get:

POSITIONS ARE MISSING. AUTO DISTRIBUTE
reader.js:333:32
Uncaught Error: Cannot find Node Port element with nodeID: [f684812c-eb1a-4633-8702-8f7313495a6b] and name: [studio-port-39865]
    value DiagramEngine.js:193
    value DiagramEngine.js:215
    ob NodeWidget.js:101
    Lodash 4
    ob NodeWidget.js:100
    value NodeWidget.js:91
    React 2
    unstable_runWithPriority scheduler.production.min.js:309
    React 4
    unstable_runWithPriority scheduler.production.min.js:309
    React 4
    Redux 6
    Be index.js:373
    promise callback*Be/< index.js:368
    r Redux
    loadPackInEditor PackLibrary.js:465
    onEditLibraryPack PackLibrary.js:216
    promise callback*A/n.onEditLibraryPack/< PackLibrary.js:214
    React 12
    unstable_runWithPriority scheduler.production.min.js:309
    React 3
DiagramEngine.js:193
Uncaught Error: Cannot find Node Port element with nodeID: [bcb45e00-50b5-45a7-a1d2-97156bf550a6] and name: [studio-port-39869]
    value DiagramEngine.js:193
    value DiagramEngine.js:215
    ob NodeWidget.js:101
    Lodash 4
    ob NodeWidget.js:100
    value NodeWidget.js:91
    React 2
    unstable_runWithPriority scheduler.production.min.js:309
    React 4
    unstable_runWithPriority scheduler.production.min.js:309
    React 4
    Redux 6
    Be index.js:373
    promise callback*Be/< index.js:368
    r Redux
    loadPackInEditor PackLibrary.js:465
    onEditLibraryPack PackLibrary.js:216
    promise callback*A/n.onEditLibraryPack/< PackLibrary.js:214
    React 12
    unstable_runWithPriority scheduler.production.min.js:309
    React 3
DiagramEngine.js:193
Uncaught Error: Cannot find Node Port element with nodeID: [3f1c2ef0-97bd-4823-88ca-85fd2e0aa06c] and name: [studio-port-39873]
    value DiagramEngine.js:193
    value DiagramEngine.js:215
    ob NodeWidget.js:101
    Lodash 4
    ob NodeWidget.js:100
    value NodeWidget.js:91
    React 2
    unstable_runWithPriority scheduler.production.min.js:309
    React 4
    unstable_runWithPriority scheduler.production.min.js:309
    React 4
    Redux 6
    Be index.js:373
    promise callback*Be/< index.js:368
    r Redux
    loadPackInEditor PackLibrary.js:465
    onEditLibraryPack PackLibrary.js:216
    promise callback*A/n.onEditLibraryPack/< PackLibrary.js:214
    React 12
    unstable_runWithPriority scheduler.production.min.js:309
    React 3
DiagramEngine.js:193
Uncaught Error: Cannot find Node Port element with nodeID: [363057e4-66fe-4835-b3f3-891b2677426d] and name: [studio-port-39877]
    value DiagramEngine.js:193
    value DiagramEngine.js:215
    ob NodeWidget.js:101
    Lodash 4
    ob NodeWidget.js:100
    value NodeWidget.js:91
    React 2
    unstable_runWithPriority scheduler.production.min.js:309
    React 4
    unstable_runWithPriority scheduler.production.min.js:309
    React 4
    Redux 6
    Be index.js:373
    promise callback*Be/< index.js:368
    r Redux
    loadPackInEditor PackLibrary.js:465
    onEditLibraryPack PackLibrary.js:216
    promise callback*A/n.onEditLibraryPack/< PackLibrary.js:214
    React 12
    unstable_runWithPriority scheduler.production.min.js:309
    React 3
DiagramEngine.js:193
Uncaught Error: Cannot find Node Port element with nodeID: [29e400dd-7e6e-4ea3-a0ca-995f8c3028d4] and name: [studio-port-39881]
    value DiagramEngine.js:193
    value DiagramEngine.js:215
    ob NodeWidget.js:101
    Lodash 4
    ob NodeWidget.js:100
    value NodeWidget.js:91
    React 2
    unstable_runWithPriority scheduler.production.min.js:309
    React 4
    unstable_runWithPriority scheduler.production.min.js:309
    React 4
    Redux 6
    Be index.js:373
    promise callback*Be/< index.js:368
    r Redux
    loadPackInEditor PackLibrary.js:465
    onEditLibraryPack PackLibrary.js:216
    promise callback*A/n.onEditLibraryPack/< PackLibrary.js:214
    React 12
    unstable_runWithPriority scheduler.production.min.js:309
    React 3
DiagramEngine.js:193
Uncaught Error: Cannot find Node Port element with nodeID: [fa6e28d2-9d63-4404-b5bb-e8772c5e0681] and name: [studio-port-39885]
    value DiagramEngine.js:193
    value DiagramEngine.js:215
    ob NodeWidget.js:101
    Lodash 4
    ob NodeWidget.js:100
    value NodeWidget.js:91
    React 2
    unstable_runWithPriority scheduler.production.min.js:309
    React 4
    unstable_runWithPriority scheduler.production.min.js:309
    React 4
    Redux 6
    Be index.js:373
    promise callback*Be/< index.js:368
    r Redux
    loadPackInEditor PackLibrary.js:465
    onEditLibraryPack PackLibrary.js:216
    promise callback*A/n.onEditLibraryPack/< PackLibrary.js:214
    React 12
    unstable_runWithPriority scheduler.production.min.js:309
    React 3
DiagramEngine.js:193
Uncaught Error: Cannot find Node Port element with nodeID: [cd3bd54d-45df-455f-af4c-455493964cf2] and name: [studio-port-39889]
    value DiagramEngine.js:193
    value DiagramEngine.js:215
    ob NodeWidget.js:101
    Lodash 4
    ob NodeWidget.js:100
    value NodeWidget.js:91
    React 2
    unstable_runWithPriority scheduler.production.min.js:309
    React 4
    unstable_runWithPriority scheduler.production.min.js:309
    React 4
    Redux 6
    Be index.js:373
    promise callback*Be/< index.js:368
    r Redux
    loadPackInEditor PackLibrary.js:465
    onEditLibraryPack PackLibrary.js:216
    promise callback*A/n.onEditLibraryPack/< PackLibrary.js:214
    React 12
    unstable_runWithPriority scheduler.production.min.js:309
    React 3
DiagramEngine.js:193
Uncaught Error: Cannot find Node Port element with nodeID: [259ea45e-07b0-4afa-8aa1-8e3847b98385] and name: [studio-port-39893]
    value DiagramEngine.js:193
    value DiagramEngine.js:215
    ob NodeWidget.js:101
    Lodash 4
    ob NodeWidget.js:100
    value NodeWidget.js:91
    React 2
    unstable_runWithPriority scheduler.production.min.js:309
    React 4
    unstable_runWithPriority scheduler.production.min.js:309
    React 4
    Redux 6
    Be index.js:373
    promise callback*Be/< index.js:368
    r Redux
    loadPackInEditor PackLibrary.js:465
    onEditLibraryPack PackLibrary.js:216
    promise callback*A/n.onEditLibraryPack/< PackLibrary.js:214
    React 12
    unstable_runWithPriority scheduler.production.min.js:309
    React 3
DiagramEngine.js:193
Uncaught Error: Cannot find Node Port element with nodeID: [4eef6742-47fc-4371-a674-9389f5d69599] and name: [studio-port-39897]
    value DiagramEngine.js:193
    value DiagramEngine.js:215
    ob NodeWidget.js:101
    Lodash 4
    ob NodeWidget.js:100
    value NodeWidget.js:91
    React 2
    unstable_runWithPriority scheduler.production.min.js:309
    React 4
    unstable_runWithPriority scheduler.production.min.js:309
    React 4
    Redux 6
    Be index.js:373
    promise callback*Be/< index.js:368
    r Redux
    loadPackInEditor PackLibrary.js:465
    onEditLibraryPack PackLibrary.js:216
    promise callback*A/n.onEditLibraryPack/< PackLibrary.js:214
    React 12
    unstable_runWithPriority scheduler.production.min.js:309
    React 3
DiagramEngine.js:193
[…] And so on…

EDIT: same with beta 3

marian-m12l commented 3 years ago

@vpoulailleau The first error can happen if a stage node has an "ok" transition configured but the "ok" button not enabled. Can you share the story.json? If the pack was converted with an earlier version, you can try with the latest one. The second error ("Cannot find Node Port element with nodeID") should not prevent the story pack to be loaded. Do you get an error notification? Maybe the node positioning fails somehow..

vpoulailleau commented 3 years ago

@marian-m12l I can't convert yet with the latest version (#183).

In the second pack, the positioning is strange. But the main problem is that the story is not well played by the device (it seems that some transitions are not working, we then have to restart the device).

For the first pack, I think you're right. Here is a partial JSON:

        {
            "uuid": "1e03c17a-82ea-442b-9913-e0c2480b32cd",
            "image": null,
            "audio": null,
            "okTransition": {
                "actionNode": "c7b52086-f877-4fb3-ab3f-3157cdbbd626",
                "optionIndex": 0
            },
            "homeTransition": {
                "actionNode": "fdcda3e3-cbf4-43b4-b018-6a08a2643067",
                "optionIndex": 0
            },
            "controlSettings": {
                "wheel": false,
                "ok": false,
                "home": true,
                "pause": false,
                "autoplay": false
            }
        },

The JSON file is too long, do you want me to upload it?

Can the parsing of the story be more permissive (ignoring okTransition if the "ok" button is not enabled)?

marian-m12l commented 3 years ago

@vpoulailleau #183 should be fixed now. but it could just be that the original story pack is malformed that way (button disabled but transition configured). When loading in the editor, the ok "port" is only added to the node if the button is enabled, so the transition cannot be added.

vpoulailleau commented 3 years ago

@marian-m12l The loading in the editor fails and the editor doesn't open, so the story can't be edited.

Here is the web browser's console message with #183 version:

failed to load story pack TypeError: t.okPort is undefined
    ge reader.js:258
    ge reader.js:256
index.js:357:24
    Be index.js:357

marian-m12l commented 3 years ago

@vpoulailleau Did you just convert the story pack to archive format? Are was it previously converted? What is the original format of the story pack?

vpoulailleau commented 3 years ago

@marian-m12l I had the official story pack (filesystem format), I converted it to an editable story pack (with #183 version), and I get the error when opening the generated editable story.

With other stories, it works well, we can inspect how story packs were made to copy their structures.

marian-m12l commented 3 years ago

@vpoulailleau then I guess the editor parser should be more lenient and throw warnings when dealing with this kind of situations.

marian-m12l commented 1 month ago

I'm closing issues from past years. Feel free to reopen if needed.

marian-m12l / studio

Failed to load story pack #188