search

marian-nmt / marian-dev

Fast Neural Machine Translation in C++ - development repository
https://marian-nmt.github.io
Other
255 stars 125 forks source link

Empty line in batch breaks batch pruning in beam search #582

Open emjotde opened 4 years ago

emjotde commented 4 years ago

Empty line in batch breaks batch pruning in beam search. We remove finished batch entries during beam-search. This fails when an entry in the batch is empty.

snukky commented 4 years ago

Added regression tests for that (https://github.com/marian-nmt/marian-regression-tests/compare/fe5c7e1beb1d9fca74b4e37e49f5d1e65aacf8aa...2ea0343b747e26a457c94de76e8856ea2434bd37). Empty lines are now handled in decoding, scoring, and validation translation.