search

marian-nmt / marian-regression-tests

Regression tests for the marian-dev repository
Other
4 stars 9 forks source link

test_scores_cpu failing #75

Closed jerinphilip closed 3 years ago

jerinphilip commented 3 years ago

Cannot find this option to fix this for browsermt/marian-dev, which seem to have diverged from marian-nmt/marian-dev. Some help finding the issue?

tests/scorer/scores/test_scores_cpu.sh is failing with the following message. 

[2021-01-27 19:44:55] [marian] /mnt/bil0/jerin/code/marian-dev/build/marian-scorer -c /fs/bil0/jerin/code/marian-regression-tests/models/wmt16_systems/marian.en-de.scorer.yml --cpu-threads 2 -t /fs/bil0/jerin/code/marian-regression-tests/tests/scorer/scores/scores_cpu.src.in /fs/bil0/jerin/code/marian-regression-tests/tests/scorer/scores/scores_cpu.trg.in
[2021-01-27 19:44:56] Error: Required option 'use-legacy-batching' has not been set
[2021-01-27 19:44:56] Error: Aborted from T marian::Options::get(const char*) const [with T = bool] in /fs/bil0/jerin/code/marian-dev/src/common/options.h:134
[CALL STACK]
[0x6eef91]          bool marian::Options::  get  <bool>(char const*) const + 0x2a1
[0xa11cf0]          marian::cpu::Backend::  configureDevice  (std::shared_ptr<marian::Options const>) + 0xa0
[0x6ff0d4]          marian::Rescore<marian::Rescorer>::  Rescore  (std::shared_ptr<marian::Options>) + 0x5f4
[0x701c19]          std::shared_ptr<marian::Rescore<marian::Rescorer>> marian::  New  <marian::Rescore<marian::Rescorer>,std::shared_ptr<marian::Options>&>(std::shared_ptr<marian::Options>&) + 0x59
[0x66d532]          main                                               + 0x52
[0x7f9068861840]    __libc_start_main                                  + 0xf0
[0x69f789]          _start                                             + 0x29
test_scores_cpu.sh: line 18:  8568 Aborted                 (core dumped) $MRT_MARIAN/marian-scorer -c $MRT_MODELS/wmt16_systems/marian.en-de.scorer.yml --cpu-threads 2 -t $(pwd)/scores_cpu.src.in $(pwd)/scores_cpu.trg.in > scores_cpu.out

Build link: http://vali.inf.ed.ac.uk/jenkins/job/browsermt-marian-regression-tests/6/

snukky commented 3 years ago

This issue should be opened in browsermt/marian-dev. This test checks basic scoring on CPU, but it fails only because that new option has not been added to marian-scorer. Fixing this may be as simple as adding it there (or not, if you get output diffs then too).