mariano / snakefire

A Linux desktop client for Campfire
http://snakefire.org
MIT License
99 stars 24 forks source link

Messages with links appear out of order #68

Open iangreenleaf opened 11 years ago

iangreenleaf commented 11 years ago

When I join a room, messages that begin with a URL appear last in the sent messages, out of order. I think I know why. Inline links trigger this predicate:

def needsThread(self):
    return self._message.is_upload() or (self._message.body and self._isInlineLink(self._message.body))

It looks like these messages get rendered in a thread, which is probably why they don't end up in he right order.

Possibly #59 has the same cause.

basilgohar commented 11 years ago

I've observed this behaviour as well. I was wondering why that would happen, and working in a thread would explain it.

goblin commented 11 years ago

:+1: