In-preview Image selection problem

[GoogleCodeExporter]

Looking at an image field control. Checked on an image. Now what? Do I
close it? 
We need 2 icons: save and clear. 
Save closes the field and keeps the value. 
Clear clears the field and keeps it open.
This may be even more confusing.

Original issue reported on code.google.com by zetapri...@gmail.com on 16 Apr 2010 at 8:33

[GoogleCodeExporter]

The same problem is with text fields. 
Do this for both:

Show normal closing X if no change has been made since opening. Clicking on the 
X
closes the control.

Show SAVE and Clear buttons if a change was made to a text field. SAVE closes 
the
control, value retained. CLEAR clears the control, replaces SAVE and CLEAR with 
a X
as nothing happened. CLEAR for image fields chooses LEAVE BLANK.

Original comment by zetapri...@gmail.com on 16 Apr 2010 at 8:57

[GoogleCodeExporter]

Original comment by zetapri...@gmail.com on 15 Sep 2010 at 7:12

• Added labels: Stream-InPreview

[GoogleCodeExporter]

Original comment by zetapri...@gmail.com on 9 Feb 2011 at 5:24

[GoogleCodeExporter]

Need mockups.
You can add new icons to 
http://code.google.com/p/magento-w2p/source/browse/trunk/skin/frontend/default/z
ptheme/images/zp-text-field-editor/sprites.png file.

Original comment by Anatoly....@gmail.com on 18 Feb 2011 at 9:03

[GoogleCodeExporter]

This doesn't look like the right sprite to me. Anatoly, can you attach the 
sprite, please?

Original comment by agur...@gmail.com on 18 Feb 2011 at 10:16

[GoogleCodeExporter]

Oh, sorry. You're a right this is not right sprite.

Hm, we don't have any sprite for in-preview editing. Please, create new one.
And add save button icon there. Get the icon from 
http://magento-w2p.googlecode.com/svn/trunk/skin/frontend/default/zptheme/images
/save-button.png

Original comment by Anatoly....@gmail.com on 18 Feb 2011 at 10:52

[GoogleCodeExporter]

Before user uploads/selects an image - before_edit.png
After uploading/selecting an image - edited.png
sprite - in_prev_edit_sprite.png

Note. Might be better to make the button through HTML. The transparent white X 
icon is used and available in other places and sprites. I can also add it here 
if needed. 
If you prefer doing it through HTML, use 1px solid #ffffff border and 
background-color:#cd6000;

Original comment by agur...@gmail.com on 18 Feb 2011 at 11:02

Attachments:

• before_edit.png
• edited.png
• in-prev-edit_sprite.png

[GoogleCodeExporter]

Interesting. We use the same X for DELETE and CLOSE.
I'm probably too picky here, but it is a bit confusing.
Let's go ahead with the mockup as is now and change the sprite later.

Original comment by zetapri...@gmail.com on 19 Feb 2011 at 7:30

[GoogleCodeExporter]

Original comment by zetapri...@gmail.com on 20 Feb 2011 at 10:18

• Added labels: Unit-0.5

[GoogleCodeExporter]

Diffs: http://code.google.com/p/magento-w2p/source/detail?r=1388

Original comment by Anatoly....@gmail.com on 21 Feb 2011 at 6:02

• Changed state: Finished

[GoogleCodeExporter]

Atanas, please use attached file to install w2p on mageimage.

Original comment by Anatoly....@gmail.com on 22 Feb 2011 at 11:58

• Changed state: ToTest

Attachments:

• web_to_print_store_incl_theme-1.8.4.0alpha28.tgz

[GoogleCodeExporter]

Tested on:
http://ec2-174-129-95-130.compute-1.amazonaws.com/mageimage/index.php/magentot-0
1/4xpage-sign.html
http://ec2-174-129-95-130.compute-1.amazonaws.com/mageimage/index.php/magentot-0
1/cent21-square-01.html

in IE7, IE8, FF, Chrome, Safari and Opera. 
X button stays on until the field is edited for the first time or after it was 
once closed. For image field it also stays on if "blank" option is selected. 
Save button appears right after any change/input/selection.

Original comment by agur...@gmail.com on 23 Feb 2011 at 11:03

• Changed state: TestOK

[GoogleCodeExporter]

Found a bug on this one.
Save button doesn't show up after chosing a color with the color picker:
http://ec2-174-129-95-130.compute-1.amazonaws.com/mageimage/index.php/magentot-0
1/1pg-template.html
- Click on the background
- Use the color picker and select the color
- The corner button does not change into a "Save" button

Original comment by agur...@gmail.com on 24 Feb 2011 at 12:54

• Changed state: MoreWork

[GoogleCodeExporter]

Diff: 
http://code.google.com/p/magento-w2p/source/diff?spec=svn1408&r=1408&format=side
&path=/trunk/skin/frontend/default/zptheme/js/zp-personalization-form.js

Original comment by Anatoly....@gmail.com on 28 Feb 2011 at 1:13

• Changed state: Finished

[GoogleCodeExporter]

Please, use 1.8.4.0alpha29 release for testing

Original comment by Anatoly....@gmail.com on 28 Feb 2011 at 2:53

• Changed state: ToTest

[GoogleCodeExporter]

Do I need the extension package to install on /mageimage/?
Magento Connect Manager throws up an err there.

Original comment by agur...@gmail.com on 1 Mar 2011 at 9:00

[GoogleCodeExporter]

Yes, you have to install it from m-c. Which error does it throw up?

Original comment by Anatoly....@gmail.com on 1 Mar 2011 at 10:47

[GoogleCodeExporter]

Original comment by agur...@gmail.com on 1 Mar 2011 at 10:54

Attachments:

• m-c_err.png

[GoogleCodeExporter]

Atanas, could you please re-install mageimage and install latest w2p release 
from m-c.

If you don't have enough time, write me and I will install 1.8.4.0alpha29 
release by hands.

Original comment by Anatoly....@gmail.com on 2 Mar 2011 at 10:48

[GoogleCodeExporter]

Using latest alpha setting I got
web_to_print_store_incl_theme   1.8.4.0alpha26 (alpha)
installed, not alpha29

any clues?

btw, had to use m-c 2.0 ext key.

Original comment by agur...@gmail.com on 2 Mar 2011 at 11:20

• Changed state: MoreWork

[GoogleCodeExporter]

Anataly, this is holding up testing on all issues. 
Please install alpha 29 manually if there's no other way so that I can test 
everything.

Original comment by agur...@gmail.com on 2 Mar 2011 at 12:34

[GoogleCodeExporter]

I don't know what's going on with m-c :-(

I've installed alpha30 by hands. Use it for testing

Original comment by Anatoly....@gmail.com on 2 Mar 2011 at 5:05

• Changed state: ToTest

[GoogleCodeExporter]

Original comment by agur...@gmail.com on 2 Mar 2011 at 6:30

• Changed state: TestOK

[GoogleCodeExporter]

1. no images in the user cache
2. uploaded an image for 1 field
3. clicked on another field
4. the default tab is UPLOAD, not MY IMAGES

If this was in the fields it would be MY IMAGES tab.

What really worries me is why do we have these discrepancies at all?
Is there duplication of functionality with the same code spliced twice?
Please, talk me through.

Original comment by zetapri...@gmail.com on 2 Mar 2011 at 7:57

• Changed state: MoreWork

[GoogleCodeExporter]

hm, this didn't happen to me.

I understand why you see no images in user cache, that is because /mageimage/ 
was reinstalled. But don't understand why you image library is not being filled 
with uploaded images and updated across all image fields... Just tried it again 
and worked for me.

Original comment by agur...@gmail.com on 2 Mar 2011 at 8:19

[GoogleCodeExporter]

Misunderstanding.
The images are in the library, but the default tab is UPLOAD, not MY IMAGES

Original comment by zetapri...@gmail.com on 2 Mar 2011 at 9:08

[GoogleCodeExporter]

Simply some of code are not invoked.

Original comment by Anatoly....@gmail.com on 3 Mar 2011 at 5:52

[GoogleCodeExporter]

Original comment by zetapri...@gmail.com on 4 Mar 2011 at 8:21

• Added labels: Period-2011-02

[GoogleCodeExporter]

The problem described by Max was solved in issue #483.

Original comment by Anatoly....@gmail.com on 17 Mar 2011 at 5:40

• Changed state: ToTest

[GoogleCodeExporter]

The last bug reported is being dealt with as a separate issue. 
http://code.google.com/p/magento-w2p/issues/detail?id=483
This one can be closed.

Original comment by agur...@gmail.com on 18 Mar 2011 at 12:53

• Changed state: TestOK

[GoogleCodeExporter]

Original comment by zetapri...@gmail.com on 27 Mar 2011 at 7:32

• Changed state: Done