Full size fancybox for large previews

[GoogleCodeExporter]

We need to show full size previews in the fancybox.
The default size should remain as it is now. It's a good compromise.

Add a button next to X at the top right corner (design?) to expand it to the 
full size of the preview. The button changes to "collapse" (design?). 

The button only appears if the preview is larger than what is shown.

Some items such as letterheads have small fonts on a large sheet. Can't be read.

Printers can control the default preview size per template. Let them do it.

Features: normal size preview, real size, big or small, all under control
Help: how to control default preview size. We probably already have something 
along these lines.

Original issue reported on code.google.com by zetapri...@gmail.com on 8 Jul 2010 at 9:17

• Blocked on: #343, #430

[GoogleCodeExporter]

Are you sure that your browser window is smaller than image?

Original comment by jamb...@gmail.com on 19 Jan 2011 at 5:28

[GoogleCodeExporter]

This is what I get on the same link

Original comment by jamb...@gmail.com on 19 Jan 2011 at 5:29

Attachments:

• resizer.png

[GoogleCodeExporter]

Sorry, forgot that part :( results:

1. The window proportions are taken from the first image that is viewed in full 
size.
Replication instructions:
- navigate to:
http://ec2-174-129-95-130.compute-1.amazonaws.com/magento/index.php/approval/fsb
o-combo-package-yard-sign-left-and-right-arrow-signs.html
- Click on image preview to get the full screen fancybox
- click on the next page in the top thumb scroll
- click on the second page preview
You will get a stretched image (stretched.png).
Looks like the the size of the large preview fancybox is taken from the first 
image that was opened and used for all pages after that. If you open the second 
page in full size first and then go to open the first one, the fancybox size 
will be inherited from the second page and the first page will be the one that 
is stretched.
Same across all browsers.

2. This was partially discussed in comment #16
Fancybox corner button gets cut in half.
Replication instructions:
- navigate to:
http://ec2-174-129-95-130.compute-1.amazonaws.com/magento/index.php/approval/fsb
o-combo-package-yard-sign-left-and-right-arrow-signs.html
- downsize your window just enough for the full size option to be activated on 
the first page
- go to the second page and click the preview to get the fancybox
you should get half a button (half-button.png)
This happens when one page can't fit but the other one does fit full size in 
the browser window. Not a big deal but the button does look broken. Can we have 
the original circle button in these cases? 
The circle one appears when there's no need for a full size button (on large 
browser window size) when I first land on a page. Can we do the same when 
there's no need for maximization buttons on separate pages only?
Same across all browsers.

Original comment by agur...@gmail.com on 19 Jan 2011 at 6:21

Attachments:

• stretched.png
• half-button.png

[GoogleCodeExporter]

This seems like an issue, can we take this as separate bug?

Original comment by jamb...@gmail.com on 19 Jan 2011 at 6:42

[GoogleCodeExporter]

Posted
http://code.google.com/p/magento-w2p/issues/detail?id=430

Original comment by agur...@gmail.com on 19 Jan 2011 at 6:52

[GoogleCodeExporter]

Original comment by zetapri...@gmail.com on 20 Jan 2011 at 5:09

[GoogleCodeExporter]

Original comment by jamb...@gmail.com on 1 Feb 2011 at 9:00

• Changed state: ToTest

[GoogleCodeExporter]

Was this one
http://code.google.com/p/magento-w2p/issues/detail?id=430
implemented in the latest release?
I see some of the old problems.

Opened the second page, maximized the view, closed and then opened the first 
page and maximized its view (1pg_stretch.png)

Tested here
http://ec2-174-129-95-130.compute-1.amazonaws.com/mageimage/index.php/magentot-0
1/4xpage-sign.html
on v. 1.8.4.0alpha23

Original comment by agur...@gmail.com on 3 Feb 2011 at 12:30

• Changed state: MoreWork

Attachments:

• 1pg_stretch.png

[GoogleCodeExporter]

Also... the "half button" issue is still here. Thought this was fixed with #430

Original comment by agur...@gmail.com on 3 Feb 2011 at 12:31

[GoogleCodeExporter]

I don't know if it was merged.

Original comment by jamb...@gmail.com on 3 Feb 2011 at 1:39

[GoogleCodeExporter]

Status of the #430 is Merge, so it means the hasn't been merged in to trunk.

Original comment by Anatoly....@gmail.com on 3 Feb 2011 at 3:48

[GoogleCodeExporter]

Just merge it. No need to wait.

Original comment by zetapri...@gmail.com on 3 Feb 2011 at 11:00

[GoogleCodeExporter]

This should be closed

Original comment by jamb...@gmail.com on 22 Feb 2011 at 7:38

• Changed state: ToTest

[GoogleCodeExporter]

Original comment by zetapri...@gmail.com on 22 Feb 2011 at 11:19

• Changed state: Docos

[GoogleCodeExporter]

What docos? This is simple JavaScript file no configuration required.

Original comment by jamb...@gmail.com on 23 Feb 2011 at 7:48

[GoogleCodeExporter]

The help post show explain what happens when an image is clicked and how to get 
large previews generated by ZP.

This also should be mentioned in features.

Original comment by zetapri...@gmail.com on 23 Feb 2011 at 8:06

[GoogleCodeExporter]

This feature adds maximize/restore option for fancybox.
When visible area of a web page is smaller then the image that would be shown, 
fancybox resizes it self so that entire image is visible. This happens when 
autoScale option of fancybox is set to true.
Some times images represent detailed objects that need to be seen in full size. 
This function adds this ability by providing a maximize/restore button that is 
visible only if image shown is smaller then its actual dimensions.
To add this to a fancybox object you need to register `fancybox_resizing_add` 
function in fancybox's onComplete handler and pass fancybox object as only 
argument to the function call like this:

if (window.fancybox_resizing_add)
        fancybox_resizing_add(this);

Original comment by jamb...@gmail.com on 7 Mar 2011 at 12:54

[GoogleCodeExporter]

Is the description in previous code good enough or you need more details?

Original comment by jamb...@gmail.com on 7 Mar 2011 at 12:55

• Changed state: ToTest

[GoogleCodeExporter]

The explanation of what it does and when it happens is pretty good and should 
be sufficient for the features and help posts I will write.

What it misses is where and what to change? That last (code) part could use a 
file path or code or whatever may be involved, that I can put in the help post. 
If it requires some .js or other files to be modified, please just give me a 
list like:
- locate file _______
- edit selector/function/whatever __________
- done
Just so that I can explain exactly how to enable/disable this option in the 
help post.

Original comment by agur...@gmail.com on 7 Mar 2011 at 3:23

• Changed state: MoreWork

[GoogleCodeExporter]

Well that is quite implementation specific. For w2p it is done in 
zp-personalization-form.js but that is already done so no need to explain, also 
the only important part is 
*To add this to a fancybox object you need to register `fancybox_resizing_add` 
function in fancybox's onComplete handler* 
anything else depends where that onComplete call is. It could be anywhere after 
fancybox is initiated or during its initiation.
There is no point of explaining how fancybox works here, for that there is 
fancyboxs' site.

Original comment by jamb...@gmail.com on 7 Mar 2011 at 3:37

[GoogleCodeExporter]

And just in case you insist to know where that exact location in the file is:
http://code.google.com/p/magento-w2p/source/browse/trunk/skin/frontend/default/z
ptheme/js/zp-personalization-form.js#792

But again, there is great chance that in next commit to this file, this 
location will change, so this is kind of pointless to show.

Original comment by jamb...@gmail.com on 7 Mar 2011 at 3:39

[GoogleCodeExporter]

Ok then. 
Will write a help post with what we have and review it then in case we need to 
provide more info to users.

Original comment by agur...@gmail.com on 7 Mar 2011 at 4:04

• Changed state: Docos

[GoogleCodeExporter]

Sure, I however miss the point of the help post. 
This is feature that we do not release by it self (it would be in different 
form if it was) and we do not provide it as an option to customers. It is going 
to be part of w2p in next stable release right? Then why the help post?

Original comment by jamb...@gmail.com on 7 Mar 2011 at 4:27

[GoogleCodeExporter]

I'm also not sure if we actually need a help post here. There's no action 
required from users, this happens on its own.

Also, is it so important that it deserves a special section here?
http://www.zetaprints.com/magento-web-to-print/features

Original comment by agur...@gmail.com on 13 May 2011 at 8:09

[GoogleCodeExporter]

@74 - agree

Original comment by ad...@zetaprints.com on 14 May 2011 at 3:57

[GoogleCodeExporter]

I wonder why no one read 73 before that or 65, I was repeating this for last 2 
months.

Original comment by jamb...@gmail.com on 14 May 2011 at 3:18

[GoogleCodeExporter]

Done?

Original comment by Anatoly....@gmail.com on 18 May 2011 at 3:44

[GoogleCodeExporter]

beh

Original comment by ad...@zetaprints.com on 18 May 2011 at 5:19

• Changed state: Done
• Removed labels: Features-X, Help-X

[GoogleCodeExporter]

Original comment by jamb...@gmail.com on 6 Jun 2011 at 7:49

• Added labels: Period-2010-12