search

marianol / JasperEmbedSample

Embedded Demo using visualize.js
GNU Affero General Public License v3.0
17 stars 8 forks source link

need centralized configuration for jrs #1

Closed ernestoongaro closed 10 years ago

ernestoongaro commented 10 years ago

Currently each file is calling the BIF.init method and passing in a hardcoded location for the server - we need to think of a way to centralize this in one file so that those not running on localhost:8080/jasperserver-pro can configure this project

marianol commented 10 years ago

We can put that config info inside visualizeHelper.js. Or probably better just one .js file that contains the config object.

marianol commented 10 years ago

I fixed this in the new code branch on 5bbde44d3da049c619729060e5ea310254d08d08 , forgot to close this in the commit message will add it in my next one. But the problem of issue #1 still exist

GeneArnold commented 10 years ago

Will these methods still work with the new version of the API?

marianol commented 10 years ago

Which methods? Centralizing the config? If it is that, yes I actually did the fix using the new version only.