search

marianosimone / epub-thumbnailer

Script to extract the cover of an epub book and create a thumbnail for it
GNU General Public License v3.0
191 stars 29 forks source link

retrieve full cover path when reading by file name #4

Closed deepbhattacharya closed 10 years ago

deepbhattacharya commented 10 years ago
  1. In the strategy for retrieving the cover file by matching its name to a regex, previously the base name was being returned from the strategy function; which led to the script failing for epubs with covers within complex folder structures. Fixed so that full path of the cover is returned. Tested on Ubuntu Trusty with GNOME desktop.
  2. While extracting covers if the original image is in CMYK mode then an error "cannot write mode CMYK as PNG" is thrown; fixed by checking mode and converting to RGB.
marianosimone commented 10 years ago

Thanks for the PR, Deep!