search

marick / Midje

Midje provides a migration path from clojure.test to a more flexible, readable, abstract, and gracious style of testing
MIT License
1.69k stars 129 forks source link

Dependency on [ordered 1.1.0] limits us to Clojure 1.3 #131

Closed marick closed 12 years ago

marick commented 12 years ago

Unfortunately, ordered-1.2 has a dependency on 1.2.1, which is even worse.

AlexBaranosky commented 12 years ago

When in doubt we can temporarily switch back to Clojure 1.3, since we don't depend on anything in 1.4

marick commented 12 years ago

Problem is that this dependency prevents our users from using Clojure 1.4. Given the following project.clj:


(defproject scratch "1.0.0-SNAPSHOT"
  :description "FIXME: write description"
  :dependencies [[org.clojure/clojure "1.4.0"]
                 [midje "1.4.0-SNAPSHOT"]])

The lib directory gets Clojure 1.3, not 1.4.

Per Alan Malloy, I switched the version of ordered to 1.2.0 and reordered the dependencies like so:

-  :dependencies ~(conj common-deps
-                       '[org.clojure/clojure "1.4.0"])
+  :dependencies ~(cons '[org.clojure/clojure "1.4.0"]
+                       common-deps)

We're still stuck with Clojure 1.3, but now it's because of core.unify.

marick commented 12 years ago

Filed a core.unify ticket.