search

marick / Midje

Midje provides a migration path from clojure.test to a more flexible, readable, abstract, and gracious style of testing
MIT License
1.69k stars 128 forks source link

Unfinished should not halt/prevent loading of autotest #316

Open arichiardi opened 9 years ago

arichiardi commented 9 years ago

My use case: I wrote a function, left unfinished during a previous working session. Now I want to start working again and I launch midje.repl/autotest.

What I see is:

======================================================================
Loading (wiki-search-xml.fetcher wiki-search-xml.search wiki-search-xml.bus wiki-search-xml.log wiki-search-xml.system wiki-search-xml.t-system wiki-search-xml.t-search wiki-search-xml.t-bus wiki-search-xml.t-fetcher wiki-search-xml.t-log wiki-search-xml.text-core wiki-search-xml.t-text-core)
= Namespace wiki-search-xml.t-system
LOAD FAILURE for wiki-search-xml.t-system
java.lang.Error: #'new-logger has no implementation, but it was called like this:
(new-logger {:searcher {}, :fetcher {:http-option-map {}}, :logger {:name "wiki-search-xml-dev-logger"}, :bus {:timeout 1000}, :version "0.1.0-SNAPSHOT"}), compiling:(wiki_search_xml/t_system.clj:4:51)

[on all the t-* that I have in the test folder]

Because failures in the initial load break autotest's dependency tracking,
autotest has been cancelled.
true
user=>

I don't know if this is the desiderata but I expected to have a simple test failure. All in all, great working experience, thanks!

arichiardi commented 9 years ago

I must add that I am a midje beginner and probably it is more idiomatic to use unfinished in some other way...