marick / Midje

Midje provides a migration path from clojure.test to a more flexible, readable, abstract, and gracious style of testing
MIT License
1.68k stars 128 forks source link

JDK 11 fixes #447

Closed puredanger closed 5 years ago

puredanger commented 5 years ago

In JDK 11, toArray with a 1-arity is now ambiguous so a type hint is needed to disambiguate. This commit fixes this in ordered-set and also arranges (by using the latest fipp which uses the latest rrb-vector which fixes the same problem in rrb-vector).

philomates commented 5 years ago

Thanks Alex! I've released this as 1.9.3

philomates commented 5 years ago

@puredanger after deploying this mijde has started to get the following warnings on startup (on java 8). I wasn't able to find anything regarding this online. Is this a known issue or should I file an issue?

Boxed math warning, clojure/core/rrb_vector/nodes.clj:88:11 - call: public static boolean clojure.lang.Numbers.lt(long,java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/nodes.clj:176:16 - call: public static long clojure.lang.Numbers.shiftLeft(long,java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/nodes.clj:177:16 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_minus(long,java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/nodes.clj:178:16 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_minus(java.lang.Object,java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/nodes.clj:179:48 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_dec(java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/nodes.clj:179:25 - call: public static long clojure.lang.Numbers.shiftRight(java.lang.Object,java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/nodes.clj:217:23 - call: public static long clojure.lang.Numbers.shiftLeft(long,java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/nodes.clj:235:29 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_add(long,java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/nodes.clj:250:11 - call: public static boolean clojure.lang.Numbers.equiv(java.lang.Object,long).
Boxed math warning, clojure/core/rrb_vector/nodes.clj:259:20 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_minus(java.lang.Object,long).
Boxed math warning, clojure/core/rrb_vector/nodes.clj:269:22 - call: public static boolean clojure.lang.Numbers.equiv(java.lang.Object,long).
Boxed math warning, clojure/core/rrb_vector/nodes.clj:273:31 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_minus(java.lang.Object,long).
Boxed math warning, clojure/core/rrb_vector/nodes.clj:275:42 - call: public static long clojure.lang.Numbers.shiftLeft(long,java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/nodes.clj:287:36 - call: public static boolean clojure.lang.Numbers.equiv(java.lang.Object,long).
Boxed math warning, clojure/core/rrb_vector/nodes.clj:290:29 - call: public static boolean clojure.lang.Numbers.equiv(java.lang.Object,long).
Boxed math warning, clojure/core/rrb_vector/nodes.clj:308:27 - call: public static boolean clojure.lang.Numbers.equiv(java.lang.Object,long).
Boxed math warning, clojure/core/rrb_vector/transients.clj:187:35 - call: public static boolean clojure.lang.Numbers.isZero(java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/transients.clj:198:41 - call: public static boolean clojure.lang.Numbers.isZero(java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/transients.clj:223:15 - call: public static boolean clojure.lang.Numbers.isZero(java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/transients.clj:257:28 - call: public static boolean clojure.lang.Numbers.isZero(java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:270:26 - call: public static boolean clojure.lang.Numbers.isPos(java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:327:29 - call: public static boolean clojure.lang.Numbers.isPos(java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:341:36 - call: public static boolean clojure.lang.Numbers.isZero(java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:356:35 - call: public static boolean clojure.lang.Numbers.isPos(java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:387:34 - call: public static boolean clojure.lang.Numbers.equiv(java.lang.Object,long).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:392:29 - call: public static boolean clojure.lang.Numbers.isPos(java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:400:39 - call: public static boolean clojure.lang.Numbers.isPos(java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:807:30 - call: public static boolean clojure.lang.Numbers.isPos(java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1001:24 - call: public static boolean clojure.lang.Numbers.isZero(java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1205:26 - call: public static boolean clojure.lang.Numbers.isPos(java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:559:32 - call: public static boolean clojure.lang.Numbers.isZero(java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1253:5 - call: public static boolean clojure.lang.Numbers.equiv(java.lang.Object,java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1282:9 - call: public static boolean clojure.lang.Numbers.isZero(java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1292:13 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_minus(java.lang.Object,long).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1314:14 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_add(java.lang.Object,java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1317:14 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_add(java.lang.Object,java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1318:30 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_dec(java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1318:24 - call: public static java.lang.Number clojure.lang.Numbers.quotient(java.lang.Object,long).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1318:19 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_inc(java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1318:14 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_minus(java.lang.Object,java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1320:7 - call: public static boolean clojure.lang.Numbers.lte(java.lang.Object,long).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1323:11 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_add(java.lang.Object,java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1323:7 - call: public static boolean clojure.lang.Numbers.lte(java.lang.Object,long).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1324:21 - call: public static boolean clojure.lang.Numbers.isZero(java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1345:22 - call: public static boolean clojure.lang.Numbers.isZero(java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1365:47 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_minus(java.lang.Object,long).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1366:42 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_minus(long,java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1378:51 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_minus(java.lang.Object,long).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1390:16 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_add(java.lang.Object,java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1393:16 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_add(java.lang.Object,java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1394:32 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_dec(java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1394:26 - call: public static java.lang.Number clojure.lang.Numbers.quotient(java.lang.Object,long).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1394:21 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_inc(java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1394:16 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_minus(java.lang.Object,java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1396:9 - call: public static boolean clojure.lang.Numbers.lte(java.lang.Object,long).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1399:13 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_add(java.lang.Object,java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1399:9 - call: public static boolean clojure.lang.Numbers.lte(java.lang.Object,long).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1448:35 - call: public static boolean clojure.lang.Numbers.gt(long,java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1449:29 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_minus(long,java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1451:33 - call: public static boolean clojure.lang.Numbers.gte(java.lang.Object,long).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1453:54 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_minus(long,java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1455:27 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_add(java.lang.Object,java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1462:32 - call: public static boolean clojure.lang.Numbers.isPos(java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1462:56 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_dec(java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1463:42 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_inc(java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1471:7 - call: public static boolean clojure.lang.Numbers.equiv(java.lang.Object,long).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1476:37 - call: public static long clojure.lang.Numbers.shiftLeft(long,java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1477:25 - call: public static boolean clojure.lang.Numbers.isZero(java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1477:35 - call: public static long clojure.lang.Numbers.shiftLeft(long,java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1484:37 - call: public static long clojure.lang.Numbers.shiftLeft(long,java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1485:25 - call: public static boolean clojure.lang.Numbers.isZero(java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1485:35 - call: public static long clojure.lang.Numbers.shiftLeft(long,java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1488:42 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_minus(java.lang.Object,long).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1491:40 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_add(java.lang.Object,java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1496:18 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_add(java.lang.Object,java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1502:18 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_minus(java.lang.Object,java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1522:30 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_add(java.lang.Object,java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1562:14 - call: public static java.lang.Object clojure.lang.Numbers.max(java.lang.Object,long).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1572:19 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_add(long,java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1573:19 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_minus(long,java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1592:52 - call: public static java.lang.Number clojure.lang.Numbers.unchecked_add(java.lang.Object,long).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1655:32 - call: public static boolean clojure.lang.Numbers.isZero(java.lang.Object).
Boxed math warning, clojure/core/rrb_vector/rrbt.clj:1859:30 - call: public static boolean clojure.lang.Numbers.isPos(java.lang.Object).
puredanger commented 5 years ago

This is coming from the updated version of org.clojure/core.rrbt. There is a newer version Available that turns off the warnings if you want to switch to that.

philomates commented 5 years ago

Ah, nice! Deployed 1.9.4 to fix this (https://github.com/marick/Midje/pull/448)