marick / Midje

Midje provides a migration path from clojure.test to a more flexible, readable, abstract, and gracious style of testing
MIT License
1.68k stars 128 forks source link

Failed prerequisites with wrong lazy sequence does not print out the lazy sequence #464

Open dfbernal opened 5 years ago

dfbernal commented 5 years ago

When evaluating a prerequisite that expects a certain lazy sequence Midje correctly fails when the lazy sequence does not match the expectation but does not return what the lazy sequence was. The following code demonstrates this:

(defn bar [lst]
  nil)

(defn foo []
  (bar (map #(hash-map :n %) [1 2])))

(fact "test"
  (foo) => [4 5]
  (provided (bar [1 2]) => [4 5]))

And the output is:

FAIL at (core.clj:10)
You never said #'bar would be called with these arguments:
    ["<an unrealized lazy sequence>"]

FAIL at (core.clj:10)
These calls were not made the right number of times:
    (bar [1 2]) [expected at least once, actually never called]

FAIL test at (core.clj:9)
Expected:
[4 5]
Actual:
"`bar` returned this string because it was called with an unexpected argument"

It would be very useful to see what the called parameters were instead of having the test output indicate that it was an unrealized lazy sequence. It would help when debugging since it allows you to see what the code was sending to the prerequisite.

philomates commented 5 years ago

Hi @dfbernal,

you mean you'd like to see

You never said #'bar would be called with these arguments:
    [({:n 1} {:n 2})]

instead of the following?

You never said #'bar would be called with these arguments:
    ["<an unrealized lazy sequence>"]

In theory we can do this, but it would mean evaluating the lazy-sequence. Since I didn't write the code that chose to print the "<an unrealized lazy sequence>" message, I don't know what trade-offs were weighed when deciding to avoid evaluating the lazy seq. @marick can you recall the details of this decision?

dfbernal commented 5 years ago

Yes, exactly. That's the feature I'd like to see if possible. It would keep me from using mapv when debugging tests 😃