search

marick / Midje

Midje provides a migration path from clojure.test to a more flexible, readable, abstract, and gracious style of testing
MIT License
1.68k stars 128 forks source link

Improve clj-kondo support for tabular #475

Closed ericdallo closed 3 years ago

ericdallo commented 3 years ago

This fix some corner (weird) tabular cases, like:

(tabular "bla"
  (fact ""
    (+ ?a ?b) => (+ ?c))
  ?a ?b ?c
  1  2  (+ 1 2))

(tabular "as"
  (fact ""
    (+ ?a ?b) => (+ ?c))
  ?a ?b ?c
  1  2  (+ 1 2))

(tabular "asd"
  (fact ""
    (+ ?a ?b) => (+ ?c))
  [?a ?b ?c]
  1  2  (+ 1 2))

(facts "asdsad"
  (tabular "asd"
    (+ ?a ?b) => (+ ?c)
    ?a ?b ?c
    1  2  (+ 1 2)))

(facts "asdsad"
  (tabular "asd"
    (+ ?a ?b) => (+ ?c)
    [?a ?b ?c]
    1  2  (+ 1 2)))
ericdallo commented 3 years ago

Done @philomates !

philomates commented 3 years ago

released as 1.10.1