search

marick / Midje

Midje provides a migration path from clojure.test to a more flexible, readable, abstract, and gracious style of testing
MIT License
1.69k stars 129 forks source link

Bump some libs + remove slingshot dep #480

Closed philomates closed 2 years ago

philomates commented 2 years ago

so people don't need to do stuff like https://github.com/nubank/matcher-combinators/pull/169/files#diff-274071745a4e2a04b647d79d500537e6dc13eee54f44d0426140026293701d1bR20-R23

I think slingshot was breaking with newer versions of clojure. I didn't bump clojure off of 1.9 though because tests related to stacktraces would need to be updated and I don't want to deal with that right now

dchelimsky commented 2 years ago

@philomates go ahead and merge/release. I'll improve the matcher-combinators update before releasing it

philomates commented 2 years ago

The CI stopped working (was Travis RIP), but with this change I don't think Midje'll work with pre-clojure 1.9:

Exception in thread "main" java.lang.RuntimeException: Unable to resolve symbol: pos-int? in this context, compiling:(puget/printer.clj:177:8)

not sure if that matters much these days. What do you think @dchelimsky

dchelimsky commented 2 years ago

I think I wouldn't care if we had succeeded at migrating away from midje in the 2 years since we agreed to do it :/

I think if we're going to make that commitment, we need to say in the release notes that midje from this new version on only supports clojure-1.10 and on. Agree?

philomates commented 2 years ago

k, I can try to open a PR on puget that does the same resolve trick to make pos-int? work with Clojure 1.8 and below

dchelimsky commented 2 years ago

Thanks!

philomates commented 2 years ago

no word from puget on https://github.com/greglook/puget/pull/55 so I'm just going to not bump puget for now and go with the other changes here

dchelimsky commented 2 years ago

Thanks @philomates. Also, hi! Hope you are well.