marick / lein-midje

Leiningen plugin for Midje
MIT License
77 stars 29 forks source link

Making lein-midje compatible with Leiningen 2 #16

Closed anttipoi closed 12 years ago

anttipoi commented 12 years ago

Hi,

I had a stab at making lein midje work with Leiningen 2. Have a look if this makes sense?

Changes:

anttipoi commented 12 years ago

The latter fix is essential, too.

AlexBaranosky commented 12 years ago

@anttipoi this isn't working for me locally. I'm getting a lot of "Could not locate ...foo.. on classpath" errors.

AlexBaranosky commented 12 years ago

@anttipoi did you check this vs lazytest as well? does the lazy-test-mode call to e-i-p also need this?:

(update-in project [:dependencies]
                    conj ['lein-midje "1.0.9"])
anttipoi commented 12 years ago

About project-2.clj: that's the project.clj you need to use if you want to build the plugin using leiningen 2. The project.clj format has changed.

On classpath issues: no, I did not try lazy-test variations. Sorry about that (and there may other ways of using midje I have not exercised ?) And yes, that probably needs the class path extension, too, if you're getting class path errors on plugin contents.

Inside e-i-p everything happens in the project classpath, and if you need to have plugins own code present you must do that extension trick.

It is annoying that that update-in riddle needs to contain plugin name and version. Especially the need to refer to version here is annoying.