search

marick / lein-midje

Leiningen plugin for Midje
MIT License
77 stars 29 forks source link

Further on: Leiningen 2 compatibility #18

Closed anttipoi closed 12 years ago

anttipoi commented 12 years ago

Now the reference to Leiningen 2 -only project namespace should not bother with Lein 1.

AlexBaranosky commented 12 years ago

@anttipoi

Could you possibly supply a list of steps to confirm this is working? I'm having a hard time not getting errors, and wonder if it isn't because I'm not following the correct steps.

This way I can confirm that what works on your machine works on mine as well, and can comfortably deploy the new plugin to clojars.

Thanks for the great work!

AlexBaranosky commented 12 years ago

@marick

also, if you check out the doc string for the midje function... all the stuff listed iwthin it shoudl still work in both leiningen 1 and 2:

"Runs both Midje and clojure.test tests. There are three ways to use this plugin:

lein midje If no namespaces are given, runs tests in all namespaces in :source-path and :test-path

lein midje ns1 ns2 ns3 Namespaces are looked up in both :source-path and :test-path. Supports simple wildcards i.e. lein midje ns.* to use all subnamespaces of ns

lein midje --lazytest Runs tests in all :source-path and :test-path namespaces.
Watches source and test namespaces, immediately running them when they change. NOTE: Requires lazytest dev-dependency."

anttipoi commented 12 years ago

I will provide test projects.

I also realized that bundling bultitude in the plugin is wrong and that it should be removed.

I'll try to do this better this time and not iterate this many times.

anttipoi commented 12 years ago

See the latest pull request for testing steps. If you have trouble could you tell me which variation gives you grief, Lein 1 or 2?

Also I noticed that at least for me the wildcards in the command line namespace args do not work:

anttipoi$ lein1 midje 'lein-test.test.core'
Copying 1 file to /Users/anttipoi/Documents/code/lein-test/lib
Copying 13 files to /Users/anttipoi/Documents/code/lein-test/lib/dev

FAIL at (core.clj:6)
    Expected: 1
      Actual: 2
FAILURE: 1 fact was not confirmed. 
anttipoi$ lein1 midje 'lein-test.test.*'
All claimed facts (0) have been confirmed.

This also occurs if I uninstall 1.0.9 and install 1.0.8 instead.