marick / lein-midje

Leiningen plugin for Midje
MIT License
78 stars 29 forks source link

lein midje exits with status 0 on FAILURE #51

Open ccfontes opened 10 years ago

ccfontes commented 10 years ago

I call lein midje from a pre-commit hook, and rely on the command exit status to proceed or abandon commit. Yet, when all tests succeed but there is some kind of unrelated failure like this one: FAILURE: These files have broken namespaces and will not be loaded., lein midje will exit with 0 status. I think this is undesirable. screen shot 2014-03-01 at 22 59 22

marick commented 10 years ago

I agree. As far as I can tell from the code, it should be returning a non-zero exit status. Therefore, I can't promise a quick fix.

marick commented 9 years ago

Added to trello board https://trello.com/c/JlAm0e0U/16-lein-midje-exits-with-status-0-on-failure-51