marick / lein-midje

Leiningen plugin for Midje
MIT License
77 stars 29 forks source link

Added green color to heading rows (>>>) #6

Closed AlexBaranosky closed 12 years ago

AlexBaranosky commented 12 years ago

The last commit's really a separate story, making lein midje work with lazytest.

AlexBaranosky commented 12 years ago

Something is funky with the lazytest code. It was running fine last night, but causing a t_exception fact to fail -- I considered that this might just be something breaking on lazytest's end. Today when I run Midje's facts via lein midje --lazytest I receive strange errors.

java.lang.ClassCastException: clojure.lang.PersistentList cannot be cast to clojure.lang.IFnERROR: #

at lazytest.watch$reload_and_run.invoke(watch.clj:22)
at lazytest.watch$reloading_runner$fn__323.invoke(watch.clj:31)
at clojure.lang.AFn.run(AFn.java:24)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)

It doesn't blow up until half way through the tests running.

Can you accept a pull request piecemeal? If so I'd say to keep the color stuff separate from the LazyTest stuff for the moment while I poke at it further.

AlexBaranosky commented 12 years ago

So I did some digging. The difference was that last night I was using: [com.intelie/lazytest "1.0.0-SNAPSHOT"]

and this afternoon I was using: [org.clojars.ninjudd/lazytest "1.1.3-SNAPSHOT"]

The com.intelie version is working, without throwing exceptions, BUT, I notice it is giving this failed fact:

FAIL at (t_exceptions.clj:39)
Actual result did not agree with the checking function.
        Actual result: (">>>lazytest.watch$reload_and_run.invoke(watch.clj:39)" ">>>lazytest.watch$start$runner__368.invoke(watch.clj:56)")
    Checking function: empty?

Somehow these two lines are ending up in the error, even though we only expect there to be one line in the error:

">>>lazytest.watch$reload_and_run.invoke(watch.clj:39)" ">>>lazytest.watch$start$runner__368.invoke(watch.clj:56)"

AlexBaranosky commented 12 years ago

Also just noticed that for some reason the summary lines don't show up when using lazytest mode.

marick commented 12 years ago

Merged semi-manually