search

marienz / nix-doom-emacs-unstraightened

Builds Doom Emacs using Nix
Apache License 2.0
27 stars 1 forks source link

Support specifying extra emacs pkgs from nixpkgs #12

Closed schwanberger closed 1 month ago

schwanberger commented 1 month ago

The following checks succeed:

I have also bumped my local doom-emacs using my config and the changes in this fork and can anecdotally attest that it works as expected for my (yet undocumented) use-case.

*EDIT: Updating checkbox status.

marienz commented 1 month ago

should likely be tweaked with a call to elisp list-packages to verify that vterm is external. What do you think?

I had the same thought. Rather than list-packages, I'd pick a package that isn't built-in (and isn't likely to become a dependency of Doom's core anytime soon... vterm would do fine for test purposes, even if it doesn't make as much sense in documentation because in normal use you'd just enable Doom's vterm module) and (require 'that-package) from the test. No need to duplicate the "not built-in" half of test-external-org for this.

schwanberger commented 1 month ago

should likely be tweaked with a call to elisp list-packages to verify that vterm is external. What do you think?

I had the same thought. Rather than list-packages, I'd pick a package that isn't built-in (and isn't likely to become a dependency of Doom's core anytime soon... vterm would do fine for test purposes, even if it doesn't make as much sense in documentation because in normal use you'd just enable Doom's vterm module) and (require 'that-package) from the test. No need to duplicate the "not built-in" half of test-external-org for this.

I've implemented a doomTest "extraPackages" that succeeds if extraPackages = epkgs: [ epkgs.vterm ]; and fails otherwise. See https://github.com/marienz/nix-doom-emacs-unstraightened/pull/12/commits/4df8b7be1519b39ef2a0a54c0ded694229d431cb

schwanberger commented 1 month ago

@marienz Seeing as my todo list for the PR is now complete I was wondering if you have any comments or new changes that you'd like. Please feel free to change/delete any changes I've made to README.md without soliciting an opinion from me 👍

marienz commented 1 month ago

Looks great! Thanks for including comprehensive documentation.