marigold-dev / batcher

The aim of the batch clearing dex is to enable users to deposit tokens with the aim of being swapped at a fair price with bounded slippage and almost no impermanent loss.
https://batcher.marigold.dev/
MIT License
10 stars 2 forks source link

Revive tests #384

Closed glottologist closed 1 year ago

glottologist commented 1 year ago

Pretty cool!

I have some minor remarks here and there but otherwise the tests work. I'm not sure why they are so slow though? You don't seem to use time-controlling operations here, or did I miss something?

You also don't test deposits that much. Did you just choose to postpone this to another PR or is something blocking else blocking?

This was the test that was originally blocked by getting the oracle price. I am working on them now, plus some redemption tests.

Regarding the slowness. Are you using "make test" ?