search

marigold-dev / chusai

MIT License
5 stars 0 forks source link

[issues 1 & 16] Inbox deposit #26

Closed Hakimba closed 2 years ago

Hakimba commented 2 years ago

Hi,

I added some include at some files because it doesn't work for me otherwise.

I'm looking forward your thoughts and suggestions !

rueshyna commented 2 years ago

I added some include at some files because it doesn't work for me otherwise.

mint_interface, wallet_interace can be imported directly because there is no chusai_ticket there.

It's the question for team, should we make the file in common can be importable? The common suppose should work like library but we might get Warning: The type of this value is ambiguous again.

rueshyna commented 2 years ago

can you add readme to describe how inbox works here?

pecornilleau commented 2 years ago

I added some include at some files because it doesn't work for me otherwise. I don't understand the problem. Is it because you rely on mint + wallet in the test ? In which case, don't ;)

mint_interface, wallet_interace can be imported directly because there is no chusai_ticket there.

It's the question for team, should we make the file in common can be importable? The common suppose should work like library but we might get Warning: The type of this value is ambiguous again.

What do you mean importable ? I think import are better than includes, to avoid ambiguity, but at the same time, currently in Ligo constructors can't be prefixed by the module in which they are defined, so it doesn't solve all problems.

rueshyna commented 2 years ago

I added some include at some files because it doesn't work for me otherwise. I don't understand the problem. Is it because you rely on mint + wallet in the test ? In which case, don't ;)

mint_interface, wallet_interace can be imported directly because there is no chusai_ticket there. It's the question for team, should we make the file in common can be importable? The common suppose should work like library but we might get Warning: The type of this value is ambiguous again.

What do you mean importable ? I think import are better than includes, to avoid ambiguity, but at the same time, currently in Ligo constructors can't be prefixed by the module in which they are defined, so it doesn't solve all problems.

If you try to import mint_interface in main branch version, you get Type "chusai_ticket" not found.. you have to include ticket_api_workaround and then include mint_interface.

To be able to importable, the change is like mint_interface in this PR.