marigold-dev / tzsafe-ui

TzSafe-UI frontend — to interact with multi-signatures wallets.
https://www.marigold.dev/tzsafe
10 stars 2 forks source link

feature: show warning message to alert users when there is a lambda execution in a proposal #110

Closed rueshyna closed 1 year ago

rueshyna commented 1 year ago

the change:

when sign the proposal: image

when reject the proposal: image

when resolve the proposal (approve): image

when resolve the proposal (reject): image

cc: @tj825

rueshyna commented 1 year ago

Overall looks good, but I do have a small problem with the design. It really looks giant compared to the transactions above. I think it can be a good idea to try:

  • adding more space between the warning and the transactions table
  • reducing a bit the line height of the text

I'm adding more warning messages this branch: https://github.com/marigold-dev/tzsafe-ui/tree/cc%40warning_message_setting I put messages in li tag. I'll also apply above suggestion with this branch. There will be easier not working on two branches. :)