marigold-dev / tzsafe-ui

TzSafe-UI frontend — to interact with multi-signatures wallets.
https://www.marigold.dev/tzsafe
10 stars 2 forks source link

[feature] display tokens, support metadata and remove beta #145

Closed rueshyna closed 8 months ago

rueshyna commented 8 months ago
JulesGuesnon commented 8 months ago

Also even if io-ts and fp-ts look quite cool, adding them only for using it here is not worth it I think. Both libraries are quite heavy:

I think there's tree shaking, so after compilation we only have the code we're using so it should makes it small, but I'm not sure it's worth it only for 1 component. If the plan is to incrementally refactor all the codebase with it, why not, but I don't think it's the plan for now

rueshyna commented 8 months ago

Also even if io-ts and fp-ts look quite cool, adding them only for using it here is not worth it I think. Both libraries are quite heavy:

  • fp-ts: 4.2mo
  • io-ts: 460kb

I think there's tree shaking, so after compilation we only have the code we're using so it should makes it small, but I'm not sure it's worth it only for 1 component. If the plan is to incrementally refactor all the codebase with it, why not, but I don't think it's the plan for now

I did really think about it's good start for refactor, have test case for each of them and start closing to get rid of any. Anyway, I'm trying the powerful tool. so I used the same way to remove this two libs and generate test cases.