search

marigold-dev / tzvote

Dapp for delegators to vote on Tezos governance. Goal is for delegates to understand what delegators want and avoid to just chose pass or vote against the crowd
https://tzvote.marigold.dev
MIT License
10 stars 3 forks source link

Add feature to share the poll #24

Closed TezBlocksBakery closed 1 year ago

TezBlocksBakery commented 1 year ago

Is it possible to add a share option for the poll that has been created? I created a poll and added all my delegators as eligible to vote on. But they have to go on the site and manually search for name of the poll which i don't think is very efficient especially if more bakers start using this to ask the same questions

zamrokk commented 1 year ago

@TezBlocksBakery I am refactoring the app and now on the url you can look at specific poll.

Btw, do you want also the votebutton on the result/details page of a poll ?

image

Right now, it is not, just on the search/list page

zamrokk commented 1 year ago

Maybe, you would like also to filter by Creator?

TezBlocksBakery commented 1 year ago

Hi Benjamin,

Yes, I believe having the vote button in the details page is more important.

Do you not think having all those different votes displayed a bit confusing?

And is it possible to create a link to a specific poll?

Kind regards, Eli

From: benjamin fuentes @.> Sent: Thursday, 7 September 2023, 14:26 To: marigold-dev/tzvote @.> Cc: TezBlocksBakery @.>; Mention @.> Subject: Re: [marigold-dev/tzvote] Add feature to share the poll (Issue #24)

@TezBlocksBakeryhttps://github.com/TezBlocksBakery I am refactoring the app and now on the url you can look at specific poll.

Btw, do you want also the vote button on the result/details page of a poll ?

[image]https://user-images.githubusercontent.com/2536368/266315652-285d1285-5660-4a9b-92bd-a4988b727bf8.png

Right now, it is not, just on the search/list page

— Reply to this email directly, view it on GitHubhttps://github.com/marigold-dev/tzvote/issues/24#issuecomment-1710060962, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A7SAUN47IGIIE7UASNVUU3DXZG4QNANCNFSM6AAAAAAXTKIQRU. You are receiving this because you were mentioned.Message ID: @.***>

TezBlocksBakery commented 1 year ago

I don't believe that would be necessary. Have you thought about an easy way to add a list of delegators?

From: benjamin fuentes @.> Sent: Thursday, September 7, 2023 2:27:27 PM To: marigold-dev/tzvote @.> Cc: TezBlocksBakery @.>; Mention @.> Subject: Re: [marigold-dev/tzvote] Add feature to share the poll (Issue #24)

Maybe, you would like also to filter by Creator ?

— Reply to this email directly, view it on GitHubhttps://github.com/marigold-dev/tzvote/issues/24#issuecomment-1710061825, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A7SAUN6G3DTERHIXJ5HJI2LXZG4S7ANCNFSM6AAAAAAXTKIQRU. You are receiving this because you were mentioned.Message ID: @.***>

zamrokk commented 1 year ago

If you have an Android , you can already test a preview on ghostnet here :

https://play.google.com/store/apps/details?id=dev.marigold.tzvote

zamrokk commented 1 year ago

Delegators : if you are baker, now you have a button to add all your delegators to the list of voters in 1 click

zamrokk commented 1 year ago

Link : I am working on this User Story next week, as each poll have specific URL now (no more SPA), so yes, you will be able to go on the result page or config page of each poll

zamrokk commented 1 year ago

I think I will rename the Settings to Details, like this we could manage + do other actions on this page

zamrokk commented 1 year ago

@TezBlocksBakery thank you for the feedback

TezBlocksBakery commented 1 year ago

Hi Benjamin,

I create polls, not with my baker wallet but with my payout wallet, could you add the option to pull delegators from any public baker?

Also i believe an option to hide polls by the poll creator would be a great addition incase a mistake has been made, i don't believe you can delete them if someone already has voted so hiding them would be the next best thing.

Maybe also hide finished polls from the main page after a week? So it doesn't get cluttered

Sorry for that i keep requesting stuff, i don't know how much work this is. Thank you that you keep working on tzvote!

Kind regards, Eli

From: benjamin fuentes @.> Sent: Friday, September 8, 2023 9:34:56 AM To: marigold-dev/tzvote @.> Cc: TezBlocksBakery @.>; Mention @.> Subject: Re: [marigold-dev/tzvote] Add feature to share the poll (Issue #24)

@TezBlocksBakeryhttps://github.com/TezBlocksBakery thank you for the feedback

— Reply to this email directly, view it on GitHubhttps://github.com/marigold-dev/tzvote/issues/24#issuecomment-1711214479, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A7SAUN7JHNQWZZIPSZM7Y7TXZLDCBANCNFSM6AAAAAAXTKIQRU. You are receiving this because you were mentioned.Message ID: @.***>

zamrokk commented 1 year ago

pull delegators from any public baker? <= why others ? Why do you need this ? Because you don't connect with your baker directly ? Do you want to connect with a Ledger instead ?

zamrokk commented 1 year ago

Also i believe an option to hide polls by the poll creator would be a great addition incase a mistake has been made, i don't believe you can delete them if someone already has voted so hiding them would be the next best thing.

<= A status to "REMOVE" or "DISABLED" , can be possible to filter out from indexer , yep ! Thx !!! Got it

zamrokk commented 1 year ago

Maybe also hide finished polls from the main page after a week? So it doesn't get cluttered

<= I can add an auto filter by end date time to last 15 days, why not

zamrokk commented 1 year ago

Just UI stuff is not a lot ^o^

Smart contract is a bit more ..

TezBlocksBakery commented 1 year ago

Indeed, i don't connect with my baker directly, instead i use my payout wallet. So, when i create a poll using my payout wallet, i need access to TEZ blocks delegators

From: benjamin fuentes @.> Sent: Friday, September 8, 2023 10:57:01 AM To: marigold-dev/tzvote @.> Cc: TezBlocksBakery @.>; Mention @.> Subject: Re: [marigold-dev/tzvote] Add feature to share the poll (Issue #24)

pull delegators from any public baker? <= why others ? Why do you need this ? Because you don't connect with your baker directly ? Do you want to connect with a Ledger instead ?

— Reply to this email directly, view it on GitHubhttps://github.com/marigold-dev/tzvote/issues/24#issuecomment-1711319959, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A7SAUN3FNTDMXCYPR3IC2MTXZLMV3ANCNFSM6AAAAAAXTKIQRU. You are receiving this because you were mentioned.Message ID: @.***>

zamrokk commented 1 year ago

Thanks a lot @TezBlocksBakery I will all of this to next release (not sure yet about the disabledas it requires some redeployment of smart contracts :/)

TezBlocksBakery commented 1 year ago

Thank you Benjamin!

From: benjamin fuentes @.> Sent: Friday, September 8, 2023 11:05:55 AM To: marigold-dev/tzvote @.> Cc: TezBlocksBakery @.>; Mention @.> Subject: Re: [marigold-dev/tzvote] Add feature to share the poll (Issue #24)

Thanks a lot @TezBlocksBakeryhttps://github.com/TezBlocksBakery I will all of this to next release (not sure yet about the disables as it requires some redeployment of smart contracts :/)

— Reply to this email directly, view it on GitHubhttps://github.com/marigold-dev/tzvote/issues/24#issuecomment-1711334607, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A7SAUNYN33NB7U7MRKHSVQLXZLNXHANCNFSM6AAAAAAXTKIQRU. You are receiving this because you were mentioned.Message ID: @.***>