bugfix: add OverlayProvider just once with the MarigoldProvider

[ti10le]

closes #1195

[changeset-bot[bot]]

🦋 Changeset detected

Latest commit: 41793146be482a2c283ededd17f9ab8b494b43a7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages

| Name | Type | | ----------------------- | ----- | | @marigold/components | Patch | | docs | Patch | | @marigold/icons | Patch | | @marigold/theme-b2b | Patch | | @marigold/theme-unicorn | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[coveralls]

Coverage decreased (-0.2%) to 99.796% when pulling 41793146be482a2c283ededd17f9ab8b494b43a7 on fix-overlay-provider into cf9b99c26af6870b9c974fb5feeed32102ef0600 on main.

[sebald]

@ti10le It's fine not to have a sheet test for this. Just test if cascading marigold providers works :)

[ti10le]

@ti10le It's fine not to have a sheet test for this. Just test if cascading marigold providers works :)

Yes we already have this test, also we have the test: OverlayProvider is present I think then its ready for final review :)

[sebald]

There is still commented out code.

[ti10le]

There is still commented out code.

But this ist from the GlobalStyles PR not from this 🙈 We can also wait until the GlobalStyles is ready 🤷🏽‍♂️

[sebald]

There is still commented out code.

But this ist from the GlobalStyles PR not from this 🙈 We can also wait until the GlobalStyles is ready 🤷🏽‍♂️

Maaaaaybe that should be fixed first then? 🤪

[ti10le]

will be fixed in #1395